JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers

[David Holmes]

On 1/02/2019 9:35 pm, Lindenmaier, Goetz wrote:
>>> Why do you remove some checks for test failures from some tests?
>>> Like
>>>     serviceability/sa/ClhsdbInspect.java
>>> Why won't jstackOutput be null any more after your change?
>>
>> I don't think it can actually be null before the change:
>> ClhsdbLauncher.run calls ClhsdbLauncher.runCmd which will either throw,
>> or return a non-null (put possibly empty) String.
>>
>> So that seems like a simple cleanup to me.
> If this holds for the other files with similar edits I listed below, too,
> consider this Reviewed by me as well.

It does - in all cases the variable ias assigned the result of 
ClhsdbLauncher.run.

Cheers,
David

> Best regards,
>    Goetz.
> 
>>> Others are:
>>>     serviceability/sa/ClhsdbJdis.java
>>>     serviceability/sa/ClhsdbLongConstant.java
>>>     serviceability/sa/ClhsdbPrintAs.java
>>>     serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java
>>>     serviceability/sa/ClhsdbScanOops.java
>>>     serviceability/sa/ClhsdbThread.java
>>>
>>> Are these all failures that go back to the attach issue?
>>>
>>> Best regards,
>>>     Goetz.
>>>
>>>
>>>> -----Original Message-----
>>>> From: Lindenmaier, Goetz
>>>> Sent: Donnerstag, 31. Januar 2019 12:54
>>>> To: 'Jini George' <jini.george at oracle.com>; serviceability-
>>>> dev at openjdk.java.net
>>>> Subject: RE: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP
>> docker
>>>> containers
>>>>
>>>> Hi Jini,
>>>>
>>>> I pushed it into our testing:
>>>> https://ci.sapmachine.io/view/Build%20My%20Branch/job/branch-build-
>>>> service/43/
>>>>
>>>> the build is running ...
>>>>
>>>> Best regards,
>>>>     Goetz.
>>>>
>>>>> -----Original Message-----
>>>>> From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net>
>> On
>>>>> Behalf Of Jini George
>>>>> Sent: Mittwoch, 30. Januar 2019 12:59
>>>>> To: serviceability-dev at openjdk.java.net
>>>>> Subject: RFR: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP
>>>> docker
>>>>> containers
>>>>>
>>>>> Requesting reviews for:
>>>>>
>>>>> BugID: https://bugs.openjdk.java.net/browse/JDK-8217473
>>>>>
>> Webrev:http://cr.openjdk.java.net/~jgeorge/8217473/webrev.01/index.html
>>>>>
>>>>> The patch includes changes to use SkippedException to skip the tests
>>>>> when canPtraceAttachLinux() in Platform.java returns false.
>>>>>
>>>>> Thanks,
>>>>> Jini.
>>>