PING: RFR: 8217845: SA should refer const values for JVMFlag from HotSpot

[serguei.spitsyn at oracle.com]

Hi Yasumasa,

The fix looks good to me.

Thanks,
Serguei


On 2/4/19 04:30, Yasumasa Suenaga wrote:
> PING: Could you review it?
>
>>>    JBS: https://bugs.openjdk.java.net/browse/JDK-8217845
>>>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8217845/webrev.00/
>
>
> Thanks,
>
> Yasumasa
>
>
> On 2019/01/28 9:35, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> This change has passed tests as below (all of jhsdb related tests):
>>
>>   - Submit repo
>>   - All hotspot/jtreg/serviceability/sa
>>   - hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java
>>   - All jdk/sun/tools/jhsdb
>>   - jdk/tools/launcher/HelpFlagsTest.java
>>
>>
>> Comments are welcome.
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>> On 2019/01/26 13:43, Yasumasa Suenaga wrote:
>>> Hi all,
>>>
>>> Please review this change:
>>>
>>>    JBS: https://bugs.openjdk.java.net/browse/JDK-8217845
>>>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8217845/webrev.00/
>>>
>>> SA will handle `Flags` enums to get flag origin.
>>> However SA has const value for bitmask for flag, and shows as raw 
>>> (int) value.
>>> This issue is commented in [1].
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>>
>>>
>>> [1] 
>>> http://hg.openjdk.java.net/jdk/jdk/file/8c035b34248d/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java#l166