RFR 8218705: Test sun/tools/jcmd/TestJcmdDefaults.java fails on Linux

Daniil Titov daniil.x.titov at oracle.com
Sat Feb 9 17:18:36 UTC 2019


Hi David,

Thank you for reviewing this change.

You are right, these tests should be run before pushing JDK-8218705. I apologize for that. I run the usual set (tier1,tier2,tier3 and serviceability tests) but it was not enough in this case.

Best regards,
Daniil

On 2/9/19, 4:31 AM, "David Holmes" <david.holmes at oracle.com> wrote:

    Hi Daniil,
    
    The fix seems reasonable.
    
    These tests should all have been run before pushing JDK-8205654.
    
    Thanks,
    David
    ------
    
    On 9/02/2019 3:37 pm, Daniil Titov wrote:
    > Please review the change that fix the test failure.
    > 
    > The problem here is that the code in sun.tools.common.ProcessArgumentMatcher.check() method was supposed to fallback to the default mechanism for retrieving the main class name if  sun.tools.common.ProcessHelper (recently introduced in JDK-8205654) failed to detect it, but it does not. The change fixes that problem.
    > 
    > Webrev: http://cr.openjdk.java.net/~dtitov/8218705/webrev.01/
    > Bug: https://bugs.openjdk.java.net/browse/JDK-8218705
    > 
    > Thanks!
    > --Daniil
    > 
    > 
    




More information about the serviceability-dev mailing list