RFR: JDK-8218754: JDK-8068225 regression in JDIBreakpointTest

[Gary Adams]

Have to guard against multiple calls to dispose.

   Revised webrev: http://cr.openjdk.java.net/~gadams/8218754/webrev.00/
   Issue: https://bugs.openjdk.java.net/browse/JDK-8218754


On 2/12/19, 5:08 AM, gary.adams at oracle.com wrote:
> The recent change to JDK-8068225 changed the order of operations
> in Debugee.endDebugee() to wait for the debugee to exit before
> disposing of the vm on the debugger side of the connection.
> For the tests based on JDIBreakpointTest the debuggee exit
> status is not used and the tests relied on the
> debugger side dispose operation to end the test.
>
> Since JDIBreakpointTest already includes a call to wait for
> the debugee, if does not need to use endDebuggee()
> to dispose and wait for the debugee to finish.
>
> Testing in progress. The vm/mlvm tests are included in tiers 2, 3 and 6.
>
> diff --git 
> a/test/hotspot/jtreg/vmTestbase/vm/mlvm/share/jdi/JDIBreakpointTest.java 
> b/test/hotspot/jtreg/vmTestbase/vm/mlvm/share/jdi/JDIBreakpointTest.java
> --- 
> a/test/hotspot/jtreg/vmTestbase/vm/mlvm/share/jdi/JDIBreakpointTest.java
> +++ 
> b/test/hotspot/jtreg/vmTestbase/vm/mlvm/share/jdi/JDIBreakpointTest.java
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2011, 2018, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -359,7 +359,7 @@
>          }.go();
>
>          if (!debuggee.terminated())
> -            debuggee.endDebugee();
> +            debuggee.dispose();
>
>          debuggee.waitFor();
>          return true;
>