[RFR]8215622: Add dump to file support for jmap histo

臧琳 zanglin5 at jd.com
Wed Feb 13 05:26:28 UTC 2019


Dear All, 
        I have uploaded new webrev at http://cr.openjdk.java.net/~xiaofeya/8215622/webrev.08/
        Here are the changes I made:
        * fixed the grammar issue. 
        * fixed the help info of jmap -histo
        * added several unit test in BasicJmapTest.java
       Would you like to help review it? Thanks.


BRs,
Lin
________________________________________
From: serguei.spitsyn at oracle.com <serguei.spitsyn at oracle.com>
Sent: Wednesday, February 13, 2019 4:00
To: Hohensee, Paul; Joe Darcy; Daniel Fuchs; 臧琳; David Holmes; JC Beyler
Cc: serviceability-dev at openjdk.java.net
Subject: Re: [RFR]8215622: Add dump to file support for jmap histo

On 2/12/19 10:36 AM, Hohensee, Paul wrote:
> Thanks, Joe and Daniel. Doesn't seem that we need it for this case anymore, but it's good to know how to proceed in the future. :)

Agreed.

Thanks,
Serguei

>
> Paul
>
> On 2/12/19, 9:07 AM, "Joe Darcy" <joe.darcy at oracle.com> wrote:
>
>      Yes, if you make yourself the assignee, you can change the state of the
>      request (and then change the assignee back to the original person).
>
>      HTH,
>
>      -Joe
>
>      On 2/12/2019 7:38 AM, Daniel Fuchs wrote:
>      > Hi Paul,
>      >
>      > On 12/02/2019 16:27, Hohensee, Paul wrote:
>      >> I don't see a way to change the Status from Closed to anything else.
>      >> There's no option I can find to do so.
>      >
>      > It may be that only the assignee can see this.
>      > On the closed CSRs assigned to me I can see a "Back to Draft" button
>      > next to "More".
>      >
>      > Hope this helps,
>      >
>      > -- daniel
>
>



More information about the serviceability-dev mailing list