RFR: JDK-8214582: BasicJDWPConnectionTest.java: RuntimeException: Could not detect port from ''

Jean Christophe Beyler jcbeyler at google.com
Wed Feb 13 23:00:16 UTC 2019


Hi Alex,

Looks good to me too :)
Jc

On Mon, Feb 11, 2019 at 4:18 PM serguei.spitsyn at oracle.com <
serguei.spitsyn at oracle.com> wrote:

> Hi Alex,
>
> It looks Okay to me.
>
> Thanks,
> Serguei
>
>
> On 2/11/19 15:20, Alex Menkov wrote:
> > Hi all,
> >
> > Please review the fix for
> > https://bugs.openjdk.java.net/browse/JDK-8214582
> > webrev:
> > http://cr.openjdk.java.net/~amenkov/BasicJDWPConnEmptyPort/webrev/
> >
> > The change fixes race condition when debuggee (LingeredApp) touches
> > lock file, but the test haven't handled "Listening for transport ...
> > at address ..." output.
> > Now the test waits up to 10 seconds (adjusted to TIMEOUT_FACTOR) for
> > the required output.
> >
> > --alex
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190213/17485e90/attachment-0001.html>


More information about the serviceability-dev mailing list