RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

David Holmes david.holmes at oracle.com
Thu Feb 14 04:53:06 UTC 2019


<offlist>

pps. You'll also need to update the man page as it has an example 
showing the hex:

      threads
               List the threads that are currently running. For each 
thread, its name and current status are printed and
               an index that can be used in other commands. In this 
example, the thread index is 4, the thread is an
               instance of java.lang.Thread, the thread name is main, 
and it is currently running.

               4. (java.lang.Thread)0x1 main      running

Is this change really worth bothering with? What's the status of jdb (I 
was surprised to seem this is all an example!) ? Does this need a CSR 
request?

Cheers,
David
On 14/02/2019 2:36 pm, David Holmes wrote:
> PS.
> 
>   return MessageOutput.format("object description and hex id",
> 
> Need to change the message too!
> 
> David
> 
> On 14/02/2019 2:32 pm, David Holmes wrote:
>> Hi Chris,
>>
>> On 14/02/2019 1:37 pm, Chris Plummer wrote:
>>> Hi,
>>>
>>> Please review the following:
>>>
>>> http://cr.openjdk.java.net/~cjplummer/8218947/webrev
>>> https://bugs.openjdk.java.net/browse/JDK-8218947
>>
>> Are there times you may want to correlate those thread ids with ones 
>> in other logs/tools that are in hex?
>>
>> That aside:
>>
>> java.lang.Long.toString
>>
>> you don't need the java.lang part (it's always implicitly imported).
>>
>> Thanks,
>> David
>> -----
>>
>>> Tested by running the following on all supported platforms:
>>>
>>> open/test/hotspot/jtreg/vmTestbase/nsk/jdb
>>> open/test/jdk/com/sun/jdi
>>>
>>> thanks,
>>>
>>> Chris


More information about the serviceability-dev mailing list