[RFR]8215622: Add dump to file support for jmap histo

[Hohensee, Paul]

Looks good. Imo "-histo:" should be valid because it's backward compatible. Serguei, if you concur I'll push the patch for Lin.

Thanks,

Paul

On 2/17/19, 7:28 PM, "臧琳" <zanglin5 at jd.com> wrote:

    Dear All,
            Thanks a lot for your reviewing.
            Here I refined the patch to fix a minor bug that cause BasicJMapTest fail with jmap -histo:all.
            May I ask your help again to review it? http://cr.openjdk.java.net/~xiaofeya/8215622/webrev.09/
            Thanks!
    
    
    Cheers,
    Lin
    ________________________________________
    From: serguei.spitsyn at oracle.com <serguei.spitsyn at oracle.com>
    Sent: Wednesday, February 13, 2019 2:57:15 PM
    To: 臧琳; Hohensee, Paul; Joe Darcy; Daniel Fuchs; David Holmes; JC Beyler
    Cc: serviceability-dev at openjdk.java.net
    Subject: Re: [RFR]8215622: Add dump to file support for jmap histo
    
    Hi Lin,
    
    The update looks good to me.
    The only question I have if the option "-histo:" needs to be valid.
    But I feel it is not that a big problem if it is valid.
    Let's wait for other opinions.
    
    Thanks,
    Serguei
    
    
    On 2/12/19 21:26, 臧琳 wrote:
    
    Dear All,
            I have uploaded new webrev at http://cr.openjdk.java.net/~xiaofeya/8215622/webrev.08/
            Here are the changes I made:
            * fixed the grammar issue.
            * fixed the help info of jmap -histo
            * added several unit test in BasicJmapTest.java
           Would you like to help review it? Thanks.
    
    
    BRs,
    Lin
    ________________________________________
    From: serguei.spitsyn at oracle.com<mailto:serguei.spitsyn at oracle.com> <serguei.spitsyn at oracle.com><mailto:serguei.spitsyn at oracle.com>
    Sent: Wednesday, February 13, 2019 4:00
    To: Hohensee, Paul; Joe Darcy; Daniel Fuchs; 臧琳; David Holmes; JC Beyler
    Cc: serviceability-dev at openjdk.java.net<mailto:serviceability-dev at openjdk.java.net>
    Subject: Re: [RFR]8215622: Add dump to file support for jmap histo
    
    On 2/12/19 10:36 AM, Hohensee, Paul wrote:
    
    
    Thanks, Joe and Daniel. Doesn't seem that we need it for this case anymore, but it's good to know how to proceed in the future. :)
    
    
    
    Agreed.
    
    Thanks,
    Serguei
    
    
    
    
    Paul
    
    On 2/12/19, 9:07 AM, "Joe Darcy" <joe.darcy at oracle.com><mailto:joe.darcy at oracle.com> wrote:
    
         Yes, if you make yourself the assignee, you can change the state of the
         request (and then change the assignee back to the original person).
    
         HTH,
    
         -Joe
    
         On 2/12/2019 7:38 AM, Daniel Fuchs wrote:
         > Hi Paul,
         >
         > On 12/02/2019 16:27, Hohensee, Paul wrote:
         >> I don't see a way to change the Status from Closed to anything else.
         >> There's no option I can find to do so.
         >
         > It may be that only the assignee can see this.
         > On the closed CSRs assigned to me I can see a "Back to Draft" button
         > next to "More".
         >
         > Hope this helps,
         >
         > -- daniel