[aarch64-port-dev ] RFR: 8209413: AArch64: NPE in clhsdb jstack command

Nick Gasson (Arm Technology China) Nick.Gasson at arm.com
Tue Feb 19 06:21:49 UTC 2019


On 18/02/2019 17:22, Andrew Haley wrote:
>>
>> Should we do this now? There's only two places I can see:
>> StubGenerator::generate_throw_exception and the set_last_Java_frame
>> overload that takes a Label.
> 
> I hate cruft like this, but it's not actually a bug, and any change in this
> delicate area has a non-zero probability of breaking something. On the other
> hand, it would be a very low-risk change.
> 

How about this:

http://cr.openjdk.java.net/~ngasson/8209413/webrev.04/

I changed the two places that currently pass NULL to pass pc() instead 
and changed the FIXME into an assert. I think the result is much cleaner 
with no functional change. Ran jtreg with assertions enabled.

Thanks,
Nick


More information about the serviceability-dev mailing list