RFR: JDK-8214756: SA should ignore archived java heap objects that are not in use
Claes Redestad
claes.redestad at oracle.com
Sun Feb 24 11:55:20 UTC 2019
Hi Jini,
changes looks good, and thanks for verifying your fix unblock 8214712!
/Claes
On 2019-02-24 06:01, Jini George wrote:
> Thank you very much, Jiangli! Yes, I did test
> open/test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java
> after applying the changes from:
>
> http://cr.openjdk.java.net/~redestad/8214712/jdk.00/
>
> and it passed after this change.
>
> Thanks,
> Jini.
>
> On 2/24/2019 9:38 AM, Jiangli Zhou wrote:
>> Hi Jini,
>>
>> The change reflects the states of archived java objects and klass
>> metadata properly at runtime and looks good to me.
>>
>> You might have already done so, for additional testing try running
>> open/test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java
>> with the planned changes for JDK-8214712
>> <https://bugs.openjdk.java.net/browse/JDK-8214712>.
>>
>> Thanks,
>> Jiangli
>>
>> On Sat, Feb 23, 2019 at 10:00 AM Jini George <jini.george at oracle.com
>> <mailto:jini.george at oracle.com>> wrote:
>>
>> Requesting reviews for a very small change to fix:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8214756
>>
>> Webrev:
>> http://cr.openjdk.java.net/~jgeorge/8214756/webrev.00/index.html
>>
>> The proposed change is to ignore objects whose associated classes are
>> unloaded while walking the heap to create a heapdump in SA.
>>
>> Thanks,
>> Jini.
>>
More information about the serviceability-dev
mailing list