RFR(S): 8215975: [testbug] Adapt nsk tests to the PPC, S390 and AIX platforms.

[Volker Simonis]

Looks good to me.

Thanks,
Volker


On Wed, Jan 2, 2019 at 4:48 PM Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
wrote:

> Hi Gary,
>
> as promised, I'll do a follow up fixing all these.
> But all the tests you mention are either not configured for aix (@requires
> linux etc)
> or are passing currently.  So no need for action here.
>
> I just want to do a fix for the nsk tests.
> So can I consider my updated webrev as reviewed by you?
> http://cr.openjdk.java.net/~goetz/wr18/8215975-nskTests/02/
>
> Best regards,
>   Goetz.
>
>
> > -----Original Message-----
> > From: gary.adams at oracle.com <gary.adams at oracle.com>
> > Sent: Montag, 31. Dezember 2018 16:59
> > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; serviceability-dev
> > (serviceability-dev at openjdk.java.net) <
> serviceability-dev at openjdk.java.net>
> > Subject: Re: RFR(S): 8215975: [testbug] Adapt nsk tests to the PPC, S390
> and
> > AIX platforms.
> >
> > Here are few more DYLD_LIBRARY_PATH locations that would be worth
> > checking
> >
> > ./jdk/vm/JniInvocationTest.java:50: env.compute("DYLD_LIBRARY_PATH", (k,
> > v) -> (k == null) ? libdir : v + ":" + libdir);
> > ./jdk/tools/launcher/ExecutionEnvironment.java:66:            ?
> > "DYLD_LIBRARY_PATH"
> > ./jdk/tools/launcher/JliLaunchTest.java:56:            String
> > LD_LIBRARY_PATH = Platform.isOSX() ? "DYLD_LIBRARY_PATH" :
> > "LD_LIBRARY_PATH";
> > ./jdk/sun/security/krb5/auto/BasicProc.java:311:
> > p.env("DYLD_LIBRARY_PATH", lib.substring(0, pos));
> > ./jdk/sun/security/krb5/auto/ReplayCacheTestProc.java:402:
> > .env("DYLD_LIBRARY_PATH", libDir)
> > ./jdk/sun/security/krb5/auto/KDC.java:1725: "DYLD_LIBRARY_PATH",
> > nativePath + "/lib",
> > ./jdk/sun/security/krb5/auto/KDC.java:1818: "DYLD_LIBRARY_PATH",
> > nativePath + "/lib",
> > ./hotspot/jtreg/vmTestbase/ExecDriver.java:122: name = Platform.isOSX()
> > ? "DYLD_LIBRARY_PATH" : "LD_LIBRARY_PATH";
> > ./hotspot/jtreg/runtime/signal/SigTestDriver.java:72: (Platform.isOSX()
> > ? "DYLD_LIBRARY_PATH" : "LD_LIBRARY_PATH");
> >
> > On 12/31/18 10:19 AM, Lindenmaier, Goetz wrote:
> > > Hi Gary,
> > >
> > >> Would it make sense to add a method to
> > test/lib/jdk/test/lib/Platform.java
> > >> similar to sharedLibraryExt() to cover the envName setting?
> > > Good point. I'll post a follow up change next year ... and believe me,
> > > that's not too far in the future ��
> > > I'd like to keep this out of this test fix, as I want to downport it to
> > > 11 at some point and thus keep it small so that it will apply cleanly.
> > >
> > >> Are the other places DYLD_LIBRARY_PATH is set also need to be
> > >> updated for AIX?
> > > Alloc001 might need it. The other vmTestbase tests are all passing,
> > > so I didn't touch them.
> > > Webrev with alloc001:
> > > http://cr.openjdk.java.net/~goetz/wr18/8215975-nskTests/02/
> > >
> > > Best regards,
> > >    Goetz.
> > >
> > >
> > >
> > >>
> > >> On 12/31/18 8:48 AM, Lindenmaier, Goetz wrote:
> > >>> Hi,
> > >>>
> > >>> Some of the nsk tests are not properly configured for the
> > >>> above platforms:
> > >>>
> > >>>    nsk/jvmti/RetransformClasses/retransform003/TestDriver.java:
> > >>>
> > >>
> > nsk/jvmti/SetNativeMethodPrefix/SetNativeMethodPrefix002/TestDriver.ja
> > >> va
> > >>>    The tests use the path to native libraries, which is named
> "LIBPATH" on
> > >> AIX.
> > >>>    nsk/share/jdi/ArgumentHandler.java
> > >>>    Add ppc/s390/aix which don't have a shared memory connector. This
> > >> disables a row of failing tests.
> > >>> Please review this change. I would like to push it to jdk12, as it
> is a mere
> > >> test fix.
> > >>> http://cr.openjdk.java.net/~goetz/wr18/8215975-
> > nskTests/01/index.html
> > >>>
> > >>> Best regards,
> > >>>     Goetz.
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190103/7fa7750f/attachment.html>