RFR: (XS): JDK-8213457: serviceability/sa/ClhsdbInspect.java time out
Jini George
jini.george at oracle.com
Fri Jan 4 07:49:08 UTC 2019
Thank you very much, Leonid.
- Jini.
On 1/4/2019 12:18 PM, Leonid Mesnik wrote:
> Looks good.
>
> Leonid
>
>> On Jan 3, 2019, at 5:51 PM, Jini George <jini.george at oracle.com> wrote:
>>
>> The modified webrev is at:
>>
>> http://cr.openjdk.java.net/~jgeorge/8213457/webrev.01/
>>
>> I will address the moving the test out of tier1 as a separate defect.
>>
>> Thank you,
>> Jini.
>>
>> On 1/4/2019 2:38 AM, Chris Plummer wrote:
>>> On 1/3/19 11:37 AM, Leonid Mesnik wrote:
>>>>
>>>>> On Jan 3, 2019, at 10:26 AM, Jini George <jini.george at oracle.com> wrote:
>>>>>
>>>>> Thank you very much, Chris, for taking a look. I will modify the timeout value to be 480 ==> 8 minutes ==> 32 minutes for tier1. Sounds good ?
>>>>>
>>>> I think it makes a sense to move this test out of tier1. It takes too long time for tier1.
>>> Agreed. I think changing the timeout to 480 is fine, but this test does run too long for tier1.
>>> Chris
>>>>
>>>> Leonid
>>>>> Thanks!
>>>>> Jini.
>>>>>
>>>>> On 1/3/2019 9:54 PM, Chris Plummer wrote:
>>>>>> Hi Jini,
>>>>>> 2400 seems excessive. That's 40 minutes, which translates to 160 minutes for our test runs. Did you mean timeout=240? It looks like a few of the Clhsdb tests were given large timeouts that are probably much more than is needed.
>>>>>> thanks,
>>>>>> Chris
>>>>>> On 1/2/19 6:51 PM, Jini George wrote:
>>>>>>> Hello!
>>>>>>>
>>>>>>> Requesting reviews for a small fix for fixing the timeout failures of the test: ClhsdbInspect.java by increasing the timeout value.
>>>>>>>
>>>>>>> BugID: https://bugs.openjdk.java.net/browse/JDK-8213457
>>>>>>> Webrev: http://cr.openjdk.java.net/~jgeorge/8213457/webrev.00/index.html
>>>>>>>
>>>>>>> The fix has been tested with about 200 repeated runs on windows post this fix. The timeout was not observed.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Jini.
>>>>>>>
>>>>>>>
>>>>>>>
>
More information about the serviceability-dev
mailing list