RFR (M) 8212959: Remove booleans from tests in vmTestbase

David Holmes david.holmes at oracle.com
Wed Jan 9 06:31:12 UTC 2019


Hi Jc,

On 9/01/2019 4:12 pm, JC Beyler wrote:
> Hi all,
> 
> Fixing up the tests in vmTestbase to not be testing explicitly against 
> NSK_TRUE/NSK_FALSE. Here is the webrev to do that:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212959
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8212959/webrev.00/

Hold up! We don't do explicit tests when the variable is a bool/boolean 
but when it is an int, as here, we do.

Are you planning on converting everything to use bool?

Cheers,
David

> Thanks,
> Jc


More information about the serviceability-dev mailing list