RFR JDK-8216386: vmTestbase/nsk/jvmti/PopFrame/popframe005/TestDescription.java fails

Daniil Titov daniil.x.titov at oracle.com
Thu Jan 17 06:27:09 UTC 2019


Hi Alex,

The change looks good to me but I think the copyright comment needs to be updated for year 2019.
 
Thanks.

Best regards,
Daniil

On 1/16/19, 3:29 PM, "serviceability-dev on behalf of Alex Menkov" <serviceability-dev-bounces at openjdk.java.net on behalf of alexey.menkov at oracle.com> wrote:

    Hi all,
    
    please review a fix for
    https://bugs.openjdk.java.net/browse/JDK-8216386
    webrev:
    http://cr.openjdk.java.net/~amenkov/popframe005_wait_time/webrev/
    
    The fix updates WAIT_TIME to depend on test.timeout.factor system property.
    WAIT_TIME value is used as argument of Thread.join().
    For the case when the thread is expected to be alive (i.e. Thread.join() 
    exits by timeout) the timeout value is restricted by 5 seconds to avoid 
    long run time with big timeout.factor values.
    
    --alex
    
    




More information about the serviceability-dev mailing list