RFR: 8225715: jhsdb jmap fails to write binary heap dump of a jshell process

[Kevin Walls]

Hi Fairoz -

Looks good to me too.

The " -encoding utf8" in the test might be a leftover from something 
else (maybe /timeout=240 also?), you could leave it out but no problem 
either way.

Thanks!
Kevin


On 01/07/2019 05:31, Fairoz Matte wrote:
> Hi,
>
> Please review a fix that potentially handle NPE and allow heap to dump from a
> process were we get source file name as null.
>
> Background:
> For taking heap dump of JShell process, we get getSourceFileName() as null.
> Current implementation doesn't have null check.
> This fix will handle the null check and avoid breaking in call to writeObjectID(sym).
> Regression test provided with patch will demonstrate the problem.
>
> JBS bug - https://bugs.openjdk.java.net/browse/JDK-8225715
> Webrev - http://cr.openjdk.java.net/~fmatte/8225715/webrev.00/
>
> Testing: Mach5 tier1,tier2 tier3, hs-tier1, hs-tier2 and hs-tier3 tests successfully passed
>
> Thanks,
> Fairoz
>