RFR(S) 8227435: Perf::attach() should not throw a java.lang.Exception

Langer, Christoph christoph.langer at sap.com
Tue Jul 16 11:42:35 UTC 2019


Hi Ralf,

looks good. Prior to pushing you’ll have to take care of the copyright years in the files you touched ��

cc-ing hotspot-runtime, because I think it affects this area, too.

Thanks
Christoph


From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net> On Behalf Of Schmelter, Ralf
Sent: Montag, 15. Juli 2019 10:10
To: OpenJDK Serviceability <serviceability-dev at openjdk.java.net>
Subject: [CAUTION] RFR(S) 8227435: Perf::attach() should not throw a java.lang.Exception

Please review this small change. It changes the exception which will be thrown when the perf file has not yet the correct size. Instead of throwing the (not declared) java.lang.Exception, we will now throw java.io.IOException, which is expected by the calling code.

webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8227435/webrev.0/
bugreport: https://bugs.openjdk.java.net/browse/JDK-8227435

Best regards,
Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190716/c531d027/attachment-0001.html>


More information about the serviceability-dev mailing list