RFR(S) 8227868: jinfo and jstack can fail converting UTF8 output to strings

Schmelter, Ralf ralf.schmelter at sap.com
Fri Jul 19 13:33:02 UTC 2019


Hi David,

thanks for the review.

> Not sure why you chose a 8K 
> buffer when existing codes uses 256 chars?

I took it from the Reader.transferTo() method. But I've changed it to back to 256.

> There would ideally have been a regression test written for JDK-8222491 
> to demonstrate the conversion problem.

I've added a test which shows the problem for jcmd. And I've modified the basic jstack test to test for the problem too. For jinfo testing would be much harder, since it either prints already sanitized output (system properties) or values which depend on the platform encoding (flags and command line). 

Here is the update webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8227868/webrev.3/

Best regards,
Ralf


More information about the serviceability-dev mailing list