RFR(XS): 8205126: JVMTI spec incorrectly states that PopFrame cannot be called on the current thread

[serguei.spitsyn at oracle.com]

Thanks a lot, Dan!
Serguei

On 6/5/19 08:12, Daniel D. Daugherty wrote:
> On 6/5/19 2:22 AM, serguei.spitsyn at oracle.com wrote:
>> Hi Chris,
>>
>>
>> Thank you a lot for reviewing this!
>>
>>
>> On 6/4/19 22:17, Chris Plummer wrote:
>>> Hi Serguei,
>>>
>>> Although a nit, what I was getting at in the CSR discussion is this 
>>> inconsistency:
>>>
>>> 2827         The specified thread must be suspended or must be the 
>>> current thread.
>>> 2940           Thread was not the current thread and was not suspended.
>>>
>>> The second line reverses the order of the requirements given in the 
>>> first line. While both are correct, it would be nice if they both 
>>> presented the requirements in the same order. The line at 2940 used 
>>> to read:
>>>
>>> 2940           Thread was not suspended and was not the current thread.
>>>
>>> Which if left unchanged (and also used as the replacement text for 
>>> line 2852) then all the lines would consistent.
>>
>> Okay, thanks.
>>
>> Then, there are 6 similar spots in the ForceEarlyReturn<Type> 
>> functions which also have to be consistent.
>> All of them originally state this:
>>   "Thread was not the current thread and was not suspended."
>>
>> I hope, the update v2 below makes all the spots consistent.
>>
>> Updated webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8205126-jvmti-spec-popframe.2/ 
>>
>
> src/hotspot/share/prims/jvmti.xml
>     No comments.
>
> Thumbs up! Thanks for making the wording consistent.
>
> Dan
>
>
>>
>>
>> Updated JVMTI spec:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8205126-jvmti-spec-popframe.2/jvmti.html 
>>
>>
>> Updated specdiff:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8205126-jvmti-spec-popframe.2/jvmti-specdiff 
>>
>>
>>
>> Thanks,
>> Serguei
>>
>>
>>>
>>> thanks,
>>>
>>> Chris
>>>
>>> On 6/4/19 4:30 PM, serguei.spitsyn at oracle.com wrote:
>>>> Please, review a fix for the JVMTI spec bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8205126
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8205126-jvmti-spec-popframe.1/ 
>>>>
>>>>
>>>>
>>>> Related CSR:
>>>> https://bugs.openjdk.java.net/browse/JDK-8225142
>>>>
>>>> Specdiff:
>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8205126-jvmti-spec-popframe.1/jvmti-specdiff/ 
>>>>
>>>>
>>>>
>>>> Summary:
>>>>   The JVMTI PopFrame() spec does not match the implementation.
>>>>   It says the  specified thread can not be the current thread.
>>>>   The fix aligns:
>>>>    - spec with implementaion
>>>>    - PopFrame spec with ForceEarlyReturn spec
>>>>
>>>> Thanks,
>>>> Serguei 
>>>
>>>
>>
>