RFR: 8217348: assert(thread->is_Java_thread()) failed: just checking

Alex Menkov alexey.menkov at oracle.com
Sat Jun 15 00:14:09 UTC 2019


+1

--alex

On 06/14/2019 17:01, serguei.spitsyn at oracle.com wrote:
> Hi Daniil,
> 
> Great discovery!
> The fix looks good to me.
> 
> Thanks,
> Serguei
> 
> 
> On 6/14/19 4:56 PM, Daniil Titov wrote:
>> Please review the change that fixes an intermittent issue.
>>
>> The problem here is that a bitwise-AND (&) operator was used in the 
>> condition instead of a logical AND operator (&&).
>> As a result pending_thread->is_thread_fully_suspended() is always 
>> evaluated regardless of the value of at_safepoint variable.
>>
>> Webrev: http://cr.openjdk.java.net/~dtitov/8217348/webrev.01/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217348
>>
>> Thanks!
>> --Daniil
>>
>>
> 


More information about the serviceability-dev mailing list