RFR: 8225636: SA can't handle prelinked libraries
Yasumasa Suenaga
yasuenag at gmail.com
Sun Jun 16 14:30:26 UTC 2019
Hi Serguei, Chris,
Thank you for your comment.
I uploaded new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.01/
I separated a function for handling prelinked library.
Also I added some comments for its process.
Thanks,
Yasumasa
On 2019/06/15 3:48, Chris Plummer wrote:
> Hi Yasumasa,
>
> I think you should replace the embedded link with more of a textual
> description of where to look in the gdb source.
>
> I'd like to see some short comments. You have a few logical blocks of
> code that would greatly benefit from just one line saying what they are
> doing, especially the loop.
>
> thanks,
>
> Chris
>
> On 6/13/19 10:49 PM, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> Please review this change:
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8225636
>> webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.00/
>>
>> I attempted to open the core which is generated by RHEL 6, but it
>> could not .
>>
>> The OS which generated the core is set to enable prelink.
>> According to GDB implementation, load address of prelinked library
>> should be calculated by offset of link_map.l_ld and the address of
>> .dynamic section.
>>
>>
>> Thanks,
>>
>> Yasumasa
>
>
More information about the serviceability-dev
mailing list