RFR: 8218464: vmTestbase/nsk/jdi/VirtualMachine/allThreads/allthreads001/TestDescription.java failed

Gary Adams gary.adams at oracle.com
Wed Mar 6 16:59:26 UTC 2019


Looks OK to me.

On 3/5/19, 5:47 PM, serguei.spitsyn at oracle.com wrote:
> Hi Daniil,
>
> The fix looks good.
>
> Thanks,
> Serguei
>
>
> On 3/5/19 1:59 PM, Daniil Titov wrote:
>> Please review a fix for this test that intermittently fails with 
>> Graal on.
>>
>> The problem here is that the test does two consequent calls to 
>> VirtualMachine.allThreads() and checks that the number of threads 
>> returned by these calls is the same. With Graal on there is a chance 
>> that a new JVMCI compiler thread could be started between these calls 
>> that makes test to fail. The fix temporary suspends the debuggee VM 
>> while these two calls to VirtualMachine.allThreads() are made.
>>
>> Webrev: http://cr.openjdk.java.net/~dtitov/8218464/webrev.01
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8218464
>>
>> Thanks!
>> --Daniil
>>
>>
>>
>



More information about the serviceability-dev mailing list