RFR(XS): 8220707: [TESTBUG] serviceability/sa/TestHeapDumpForLargeArray.java fails with jtreg -vmoption:-Xmx < 8g

[Jean Christophe Beyler]

Hi Nick,

Not a reviewer but looks good to me :) I would perhaps put a comment above
the argument creation to note that the order is important, ie something
like:
"// Need to add the default arguments first to have explicit -Xmx8g last,
otherwise test will fail."

Thanks,
Jc


On Fri, Mar 15, 2019 at 12:32 AM Nick Gasson <nick.gasson at arm.com> wrote:

> Hi,
>
> Please review this very small test fix to
> serviceability/sa/TestHeapDumpForLargeArray.java:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8220707
> Webrev: http://cr.openjdk.java.net/~ngasson/8220707/webrev.0/
>
> If you run this test with jtreg option -vmoption:-Xmx512m (or any value
> < 8g) then it will fail with:
>
> STATUS:Failed.`main' threw exception: java.io.IOException: LingeredApp
> terminated with non-zero exit code 1
>
> LingeredAppWithLargeArray needs an -Xmx8g argument but this can be
> overriden by the -Xmx option passed to jtreg, as the default VM
> arguments are added after the explicit ones when creating the
> subprocess. It would work fine if they were added in the other order.
>
> Thanks,
> Nick
>


-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190315/cc32841d/attachment.html>