RFR (T) 8220744: Move RedefineTests to from runtime to serviceability

[coleen.phillimore at oracle.com]

On 3/19/19 10:02 AM, Daniel D. Daugherty wrote:
> On 3/19/19 7:39 AM, coleen.phillimore at oracle.com wrote:
>>
>> Sorry about this not being trivial after all.  Two of the appcds 
>> tests had the old pathname in them:
>>
>> http://cr.openjdk.java.net/~coleenp/2019/8220744.03/webrev
>
> test/hotspot/jtreg/TEST.groups
>     No comments.
>
> test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineBasicTest.java
>     No comments.
>
> test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineRunningMethods_Shared.java 
>
>     L27:  * @summary Run /runtime/RedefineTests/RedefineRunningMethods 
> in AppCDS mode to
>         You need to update this path also.

$ grep -r RedefineTests
hotspot/jtreg/runtime/logging/RedefineClasses.java: * @comment This test 
is simplified version of runtime/RedefineTests/RedefineRunningMethods.java.
hotspot/jtreg/runtime/appcds/redefineClass/RedefineRunningMethods_Shared.java: 
* @summary Run /runtime/RedefineTest/RedefineRunningMethods in AppCDS 
mode to

I fixed these in comments and summary too.  Thanks!

Coleen

>
> Did you grep for the old test names to make sure there are no
> other stale references?
>
> Dan
>
>
>
>>
>> Now tier1-3 pass.
>>
>> thanks,
>> Coleen
>>
>> On 3/15/19 9:13 PM, serguei.spitsyn at oracle.com wrote:
>>> Hi Coleen,
>>>
>>> +1
>>>
>>> Thank you for taking care about it!
>>> -Serguei
>>>
>>>
>>> On 3/15/19 5:42 PM, Chris Plummer wrote:
>>>> +1
>>>>
>>>> On 3/15/19 5:29 PM, Daniel D. Daugherty wrote:
>>>>> Thumbs up.
>>>>>
>>>>> Dan
>>>>>
>>>>>
>>>>> On 3/15/19 8:25 PM, coleen.phillimore at oracle.com wrote:
>>>>>>
>>>>>> Hi, Okay I see how it works now.  I was wondering how to tell it 
>>>>>> to ever run the tests.
>>>>>>
>>>>>> I fixed it so that the serviceability RedefineClasses tests are 
>>>>>> run in tier1 and I'll rerun tier1.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~coleenp/2019/8220744.02/webrev
>>>>>>
>>>>>> Coleen
>>>>>>
>>>>>> On 3/15/19 8:14 PM, Daniel D. Daugherty wrote:
>>>>>>> Yikes. I missed that. Here's the beginning of tier1_runtime:
>>>>>>>
>>>>>>>   L261: tier1_runtime = \
>>>>>>>   L262:   runtime/ \
>>>>>>>
>>>>>>> and here's the beginning of tier1_serviceability:
>>>>>>>
>>>>>>>   L324 tier1_serviceability = \
>>>>>>>   L325   serviceability/dcmd/compiler \
>>>>>>>
>>>>>>> I should not have assumed. Does anyone know why 
>>>>>>> tier1_serviceability
>>>>>>> isn't "start with everything" and then "filter out some stuff"?
>>>>>>>
>>>>>>> Dan
>>>>>>>
>>>>>>>
>>>>>>> On 3/15/19 8:06 PM, Chris Plummer wrote:
>>>>>>>> Hi Coleen,
>>>>>>>>
>>>>>>>> I think in TEST.groups you need to add 
>>>>>>>> serviceability/jvmti/RedefineClasses to tier1_serviceability. 
>>>>>>>> Otherwise the removes of specific tests isn't doing anything, 
>>>>>>>> and tier1_serviceability won't run the other tests you moved 
>>>>>>>> from tier1_runtime.
>>>>>>>>
>>>>>>>> thanks,
>>>>>>>>
>>>>>>>> Chris
>>>>>>>>
>>>>>>>>
>>>>>>>> On 3/15/19 4:14 PM, coleen.phillimore at oracle.com wrote:
>>>>>>>>> Summary: move tests out of runtime to jvmti/RedefineClasses
>>>>>>>>>
>>>>>>>>> These always belonged in serviceability/jvmti. Also, moved a 
>>>>>>>>> couple tests within serviceability/jvmti to RedefineClasses also.
>>>>>>>>>
>>>>>>>>> open webrev at 
>>>>>>>>> http://cr.openjdk.java.net/~coleenp/2019/8220744.01/webrev
>>>>>>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8220744
>>>>>>>>>
>>>>>>>>> I ran these tests with make test 
>>>>>>>>> TEST=open/test/hotspot/jtreg/serviceability/jvmti/RedefineClasses 
>>>>>>>>> and they passed.  Tier1 testing is in progress.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Coleen
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>