RFR: JDK-8220295: sun/tools/jps/TestJps.java still timing out

[Gary Adams]

A quick follow up on the jstat test failures.

On the failed runs the output looks like this :

----------messages:(3/127)----------
command: shell jstatLineCounts4.sh
reason: User specified action: run shell jstatLineCounts4.sh
elapsed time (seconds): 7.496
----------System.out:(13/1261)----------
   S0     S1     E      O      M     CCS    YGC     YGCT    FGC    FGCT    CGC    CGCT     GCT
   0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000
   0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000
   0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000
   0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000
   0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000
   0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000
   0.00   0.00   0.00   0.00      -  28.19      1    0.571     0    0.000     0    0.000    0.571
   0.00 100.00   0.00  14.85  31.29  28.19      1    0.571     0    0.000     0    0.000    0.571
   0.00 100.00   0.00  14.85  31.29  28.19      1    0.571     0    0.000     0    0.000    0.571
   0.00 100.00   0.00  14.85  31.29  28.19      1    0.571     0    0.000     0    0.000    0.571
   S0     S1     E      O      M     CCS    YGC     YGCT    FGC    FGCT    CGC    CGCT     GCT
   0.00 100.00   0.00  14.85  31.29  28.19      1    0.571     0    0.000     0    0.000    0.571


The awk scripts used to check the output are not aware a dash '-' is 
allowed the metaspace column.
Here is a quick stab to allow the dashes.
Is anyone aware of recent changes in the gcutil output?

diff --git a/test/jdk/sun/tools/jstat/lineCounts3.awk 
b/test/jdk/sun/tools/jstat/lineCounts3.awk
--- a/test/jdk/sun/tools/jstat/lineCounts3.awk
+++ b/test/jdk/sun/tools/jstat/lineCounts3.awk
@@ -23,7 +23,7 @@
          headerlines++;
      }

-/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+)|-[ ]*[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/    {
+/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+)|-[ ]*([0-9]+\.[0-9]+)|-[ ]*[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/    {
          datalines++;
      }

diff --git a/test/jdk/sun/tools/jstat/lineCounts4.awk 
b/test/jdk/sun/tools/jstat/lineCounts4.awk
--- a/test/jdk/sun/tools/jstat/lineCounts4.awk
+++ b/test/jdk/sun/tools/jstat/lineCounts4.awk
@@ -26,7 +26,7 @@
          headerlines++;
      }

-/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+)|-[ ]*[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/    {
+/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+)|-[ ]*([0-9]+\.[0-9]+)|-[ ]*[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ 
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/    {
          if (headerlines == 2) {
              datalines2++;
          }


On 3/19/19, 8:22 AM, Gary Adams wrote:
> After 1000 testruns on {solaris,linux,windows,macosx} debug builds
> running
>   test/jdk/sun/tools
>   test/jdk/com/sun/tools/attach
>
> with this change, no failures were observed in TestJps or TempDirTest.
>
> diff --git a/test/jdk/TEST.ROOT b/test/jdk/TEST.ROOT
> --- a/test/jdk/TEST.ROOT
> +++ b/test/jdk/TEST.ROOT
> @@ -22,7 +22,11 @@
>  javax/management sun/awt sun/java2d javax/xml/jaxp/testng/validation 
> java/lang/ProcessHandle
>
>  # Tests that cannot run concurrently
> -exclusiveAccess.dirs=java/rmi/Naming java/util/prefs 
> sun/management/jmxremote sun/tools/jstatd sun/security/mscapi 
> java/util/stream java/util/Arrays/largeMemory java/util/BitSet/stream 
> javax/rmi
> +exclusiveAccess.dirs=java/rmi/Naming java/util/prefs 
> sun/management/jmxremote \
> +sun/tools/jstatd sun/tools/jcmd sun/tools/jhsdb 
> sun/tools/jhsdb/heapconfig \
> +sun/tools/jinfo sun/tools/jmap sun/tools/jps sun/tools/jstack 
> sun/tools/jstat \
> +com/sun/tools/attach sun/security/mscapi java/util/stream 
> java/util/Arrays/largeMemory \
> +java/util/BitSet/stream javax/rmi
>  # Group definitions
>  groups=TEST.groups
>
> Failures were observed in the following tests.
> sun/tools/jstat/jstatLineCounts4.sh,[],[solaris-sparcv9-debug],[ExitCode: 
> 1],[bug4990825 shell], [jstatLineCounts4.sh],[37605],[] 
> sun/tools/jstat/jstatLineCounts4.sh,[],[solaris-sparcv9-debug],[ExitCode: 
> 1],[bug4990825 shell], [jstatLineCounts4.sh],[37605],[]   
> sun/tools/jstat/jstatLineCounts3.sh
> sun/tools/jstat/jstatLineCounts4.sh,[],[solaris-sparcv9-debug],[ExitCode: 
> 1],[bug4990825 shell], [jstatLineCounts4.sh],[37605],[] 
> sun/tools/jstat/jstatLineCounts4.sh,[],[solaris-sparcv9-debug],[ExitCode: 
> 1],[bug4990825 shell], [jstatLineCounts4.sh],[37605],[]   
> sun/tools/jstat/jstatLineCounts4.sh
>   sun/tools/jstatd/TestJstatdDefaults.java
>   sun/tools/jstatd/TestJstatdServer.java
>   sun/tools/jstatd/TestJstatdPort.java
>   sun/tools/jstatd/TestJstatdExternalRegistry.java
>
> I'll investigate those failures some more, but I don't think they are
> related to the change to exclusiveAccess.dirs.
>
> Issues:
> https://bugs.openjdk.java.net/browse/JDK-8220295
> https://bugs.openjdk.java.net/browse/JDK-8220242
>
> At this point just looking for feedback, if this is a reasonable direction
> to deal with the intermittent timeouts with theses tests to reduce the
> concurrency with other attaching tests.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190319/513371ea/attachment-0001.html>