RFR: JDK-8221164: jstatLineCounts tests need to be more resilient for NaN outputs
Jean Christophe Beyler
jcbeyler at google.com
Fri Mar 22 16:12:55 UTC 2019
Hi Gary,
Looks good to me though there's an itch to try to make the regex easier to
read/maintain :)
Jc
On Fri, Mar 22, 2019 at 1:18 AM gary.adams at oracle.com <gary.adams at oracle.com>
wrote:
> The M and CCS columns from jstat output can present a dash("-")
> for NaN values, such as :
>
> ----------System.out:(13/1261)----------
> S0 S1 E O M CCS YGC YGCT FGC FGCT CGC CGCT GCT
> 0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
> 0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
> 0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
> 0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
> 0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
> 0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
> 0.00 0.00 0.00 0.00 - 28.19 1 0.571 0 0.000 0 0.000 0.571
> 0.00 100.00 0.00 14.85 31.29 28.19 1 0.571 0 0.000 0 0.000 0.571
> 0.00 100.00 0.00 14.85 31.29 28.19 1 0.571 0 0.000 0 0.000 0.571
> 0.00 100.00 0.00 14.85 31.29 28.19 1 0.571 0 0.000 0 0.000 0.571
>
>
> This proposed fix updates the awk scripts which are checking output lines.
> For the M and CCS columns, allow either a floating point value or a dash.
> e.g. "([0-9]+\.[0-9]+|-)"
>
> Webrev: http://cr.openjdk.java.net/~gadams/8221164/webrev/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8221164
>
--
Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190322/ddfc70e0/attachment.html>
More information about the serviceability-dev
mailing list