JDK-8221164: jstatLineCounts tests need to be more resilient for NaN outputs

[Hohensee, Paul]

+1.

Paul

From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net> on behalf of Chris Plummer <chris.plummer at oracle.com>
Date: Friday, March 22, 2019 at 7:38 PM
To: "gary.adams at oracle.com" <gary.adams at oracle.com>, OpenJDK Serviceability <serviceability-dev at openjdk.java.net>
Subject: Re: RFR: JDK-8221164: jstatLineCounts tests need to be more resilient for NaN outputs

Ok. The fix looks good to me.

thanks,

Chris

On 3/22/19 4:01 PM, gary.adams at oracle.com<mailto:gary.adams at oracle.com> wrote:
Yes. I just made it clearer.

On 3/22/19 3:29 PM, Chris Plummer wrote:
Hi Gary,

It looks like there was already "-" support for the CCS column. Was it not working, or did you add the parens just to make it clearer to the reader what it is matching on?

thanks,

Chris

On 3/22/19 1:18 AM, gary.adams at oracle.com<mailto:gary.adams at oracle.com> wrote:
The M and CCS columns from jstat output can present a dash("-")
for NaN values, such as :

----------System.out:(13/1261)----------

  S0     S1     E      O      M     CCS    YGC     YGCT    FGC    FGCT    CGC    CGCT     GCT

  0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000

  0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000

  0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000

  0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000

  0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000

  0.00   0.00   0.00   0.00      -      -      0    0.000     0    0.000     0    0.000    0.000

  0.00   0.00   0.00   0.00      -  28.19      1    0.571     0    0.000     0    0.000    0.571

  0.00 100.00   0.00  14.85  31.29  28.19      1    0.571     0    0.000     0    0.000    0.571

  0.00 100.00   0.00  14.85  31.29  28.19      1    0.571     0    0.000     0    0.000    0.571

  0.00 100.00   0.00  14.85  31.29  28.19      1    0.571     0    0.000     0    0.000    0.571

This proposed fix updates the awk scripts which are checking output lines.
For the M and CCS columns, allow either a floating point value or a dash.
e.g. "([0-9]+\.[0-9]+|-)"

  Webrev: http://cr.openjdk.java.net/~gadams/8221164/webrev/<http://cr.openjdk.java.net/%7Egadams/8221164/webrev/>
  Issue:  https://bugs.openjdk.java.net/browse/JDK-8221164





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190323/321bafae/attachment.html>