RFR: 8221396: Clean up serviceability/sa/TestUniverse.java

[Jean Christophe Beyler]

Hi Per,

It looks good to me (not an official reviewer), my nit would be perhaps to
add a print when you skip a configuration just for future
debugging/understanding the log, perhaps?.

No need evidently to make a new webrev for that :)

Thanks,
Jc

On Mon, Mar 25, 2019 at 6:59 AM Per Liden <per.liden at oracle.com> wrote:

> Thanks Stefan!
>
> /Per
>
> On 3/25/19 2:44 PM, Stefan Karlsson wrote:
> > Looks good.
> >
> > StefanK
> >
> > On 2019-03-25 10:59, Per Liden wrote:
> >> Clean up serviceability/sa/TestUniverse.java to remove the need for
> >> the withZ/withoutZ option we currently pass in. This also changes the
> >> test to only run with the selected GC instead of testing all GCs every
> >> time, which should save us some cycles in testing.
> >>
> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8221396
> >> Webrev: http://cr.openjdk.java.net/~pliden/8221396/webrev.0
> >>
> >> /Per
>


-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190325/3ea872c3/attachment-0001.html>