RFR: 8220682: Heap dumping and inspection fails with JDK-8214712

[Jiangli Zhou]

Hi Claes,

The updated change also matches with the state of shared klasses, so it
seems good to me. Sorry for the delay. It's probably a good idea to add an
assert to make sure k->is_shared() in both places. No new webrev is
necessary for me for the assert change.

Thanks and regards,
Jiangli

On Mon, Mar 25, 2019 at 3:45 AM Claes Redestad <claes.redestad at oracle.com>
wrote:

> Ping.
>
> Still passes tests and is necessary to unblock work to more aggressively
> archive invariant heap graphs.
>
> /Claes
>
> On 2019-03-15 17:26, Claes Redestad wrote:
> > Hi,
> >
> > I ran into a few additional test issues, one exposing a crash in jmap
> > -histo:live in a test that seems to have been problem listed when I
> > ran tests earlier.
> >
> > Also filtering out archived-but-not-yet-loaded classes in
> > KlassInfoBucket::lookup makes tests exercising jmap etc work as intended
> > in the presence of archived classes:
> >
> > http://cr.openjdk.java.net/~redestad/8220682/open.01/
> >
> > Testing: tier1-3 with 8214712 ongoing
> >
> > /Claes
> >
> > On 2019-03-15 16:28, Jiangli Zhou wrote:
> >> +1
> >>
> >> Thanks,
> >> Jiangli
> >>
> >> On Fri, Mar 15, 2019 at 7:56 AM Jean Christophe Beyler
> >> <jcbeyler at google.com <mailto:jcbeyler at google.com>> wrote:
> >>
> >>     Hi Claes,
> >>
> >>     Looks good to me. For those who would want to see the patch change
> >>     done in the serviceability-agent:
> >>     http://hg.openjdk.java.net/jdk/jdk/rev/91f06b86c0da
> >>
> >>     Thanks,
> >>     Jc
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190325/859bc8f5/attachment.html>