RFR (S) 8223146 [TESTBUG] new test vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/ fails on Windows

[David Holmes]

Hi Jc,

On 1/05/2019 10:00 am, Jean Christophe Beyler wrote:
> Hi all,
> 
> (second day in a row is a "charm"; my apologies for the double post)
> 
> I figured out the problem for this test bug, I put additional data in 
> the bug itself for tracking.

Yep - never use "long" as its size will vary. :)

> Webrev: http://cr.openjdk.java.net/~jcbeyler/8223146/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223146

Change looks okay to me. Only query is where the INT32_MIN definition is 
coming from? I see it in stdint.h which isn't included.

> Note: If this solution is ok to all, I'll drop the problem list webrev 
> and push this one; if this lingers and I get LGTMs for the problem list, 
> I'll push that one and then we can work out this problem/solution.

Yep that's a good plan. Better to fix the bug than ProblemList.

> (I've tested this as much as I could and have pushed this on the 
> submit-repo but I'm unsure that would test this test on Windows; if 
> someone could test it, that would be perhaps a good idea as well).

I can't test on Windows either. I'll check the jdk-submit job to see 
that it does run the test on Windows as expected.

Thanks,
David

> Thanks for your help,
> Jc