RFR (S): 8223177: Data race on JvmtiEnvBase::_tag_map in double-checked locking

Man Cao manc at google.com
Thu May 2 01:00:04 UTC 2019


Thank everyone for the review!
Renamed and final webrev:
https://cr.openjdk.java.net/~manc/8223177/webrev.02/

-Man


On Wed, May 1, 2019 at 5:21 PM serguei.spitsyn at oracle.com <
serguei.spitsyn at oracle.com> wrote:

> Hi Man,
>
> Looks good to me.
>
> Minor comment:
> I'd suggest to rename tag_map_acquire to acquire_tag_map to be consistent
> with release_set_tag_map.
>
>
> Thanks,
> Serguei
>
>
> On 4/30/19 18:51, Man Cao wrote:
>
> Hi all,
>
> Can I have reviews for this small change that adds memory fences for
> double-checked locking?
> We found this race while working on the Java ThreadSanitizer project.
>
> Webrev: https://cr.openjdk.java.net/~manc/8223177/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223177
>
> -Man
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190501/204c19fd/attachment.html>


More information about the serviceability-dev mailing list