RFR (S) 8223441: HeapMonitorStatArrayCorrectnessTest fails due to sampling determinism

[Jean Christophe Beyler]

Hi all,

Could I get a review for this test fix:

Webrev: http://cr.openjdk.java.net/~jcbeyler/8223441/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8223441

Backstory is:
When I fixed https://bugs.openjdk.java.net/browse/JDK-8215113, I fixed this
failing test in the "actually make the error calculation correct". But it
turns out the test itself failed 7 out of 10 times and when we tested it,
we were apparently "lucky".

This fix makes the test pass 5k times so I am hopeful it will not show up
again.

Extra notes:
   - I fixed this by adding a loop that says: if we have not converged yet,
try again at max 5 times; generally we don't converge if the sampling
intervals chosen at the start just have pushed us far enough from the
average we expect that it takes more samples to get us back on track

Thanks,
Jc

Ps: FWIW, I'm going to look at the flakyness of the rest of the suite and
see if anything pops up to reduce the test bug noise of this suite
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190507/194a90fa/attachment.html>