debugd options should regard to jhsdb style

[Osamu Sakamoto]

Hi, David

I saw your comment in this CSR.
CSR: https://bugs.openjdk.java.net/browse/JDK-8223666

I understand that the problem is that the help description of debugd I 
proposed and current other modes is not helpful for users.

What should we do to go through this CSR?
IMHO we should update help description of all jhsdb modes more helpful.
Do you have any ideas about this?
	
Thanks,
Osamu


On 5/10/19 17:46, 坂本 統 wrote:
> Hi,
> 
> I agree with Yasumasa's opinion in CSR.
> 
> I wrote new debugd format and usage to match other modes(jstack, jmap and so on) in jhdsb.
> Certainly, usage of debugd which I proposed does not explain that <pid> and <exe> cannot be used together, but it is not limited to debugd - other modes have similar issue.
> 
> I think it is helpful to detail help description in each jhsdb modes, but I'd like to separate as another issue because this is not limited to debugd.
> 
> -----Original Message-----
> From: Yasumasa Suenaga <yasuenag at gmail.com>
> Sent: Friday, May 10, 2019 4:08 PM
> To: David Holmes <david.holmes at oracle.com>
> Cc: Jean Christophe Beyler <jcbeyler at google.com>; serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net <serviceability-dev at openjdk.java.net>; 坂本 統 <sakamoto.osamu at nttcom.co.jp>
> Subject: Re: debugd options should regard to jhsdb style
> 
> Hi David,
> 
> Thank you for checking in CSR, and sorry for my incorrect description.
> I added my opinion to CSR.
> 
> Osamu, do you have any opinion?
> 
> 
> Yasumasa
> 
> 
> 2019年5月10日(金) 15:16 David Holmes <david.holmes at oracle.com>:
>>
>> Hi Yasumasa,
>>
>> I've made some updates to the CSR request and raised a couple of issues.
>>
>> FYI the specification section only needs to contain the actual
>> specification for what has changed ie the new command-line options;
>> not the implementation that will bring about those changes.
>>
>> Thanks,
>> David
>>
>> On 10/05/2019 2:12 pm, Yasumasa Suenaga wrote:
>>> Thanks JC!
>>>
>>> I added key point of this change to specification section in CSR.
>>>
>>>
>>> Yasumasa
>>>
>>> 2019年5月10日(金) 12:54 Jean Christophe Beyler <jcbeyler at google.com>:
>>>>
>>>> Hi Yasumasa,
>>>>
>>>> I'm not a reviewer but the CSR looks good; I feel that the
>>>> specification section could use some text and then send the reader
>>>> to the other bug entry :) Jc
>>>>
>>>> From: Yasumasa Suenaga <yasuenag at gmail.com>
>>>> Date: Thu, May 9, 2019 at 8:06 PM
>>>> To: serviceability-dev at openjdk.java.net
>>>> serviceability-dev at openjdk.java.net
>>>>
>>>>> tests on submit repo have been passed
>>>>> (mach5-one-ysuenaga-JDK-8223665-20190510-0157-2376640)
>>>>>
>>>>> Could you review the CSR?
>>>>>
>>>>>>      CSR: https://bugs.openjdk.java.net/browse/JDK-8223666
>>>>>
>>>>>
>>>>> Yasumasa
>>>>>
>>>>>
>>>>> 2019年5月10日(金) 10:20 Yasumasa Suenaga <yasuenag at gmail.com>:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Osamu, your change looks good to me.
>>>>>> I will sponsor you.
>>>>>>
>>>>>> David, I filed this issue and requested to CSR:
>>>>>>
>>>>>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8223665
>>>>>>      CSR: https://bugs.openjdk.java.net/browse/JDK-8223666
>>>>>>
>>>>>> I uploaded webrev. I will push it to submit repo.
>>>>>>
>>>>>>      http://cr.openjdk.java.net/~ysuenaga/JDK-8223665/webrev.00/
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Yasumasa
>>>>>>
>>>>>>
>>>>>> On 2019/05/10 7:30, David Holmes wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> This will need a bug filed and a corresponding CSR request. I
>>>>>>> suspect that historically the form of this command was done to match other tools.
>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> David
>>>>>>>
>>>>>>> On 9/05/2019 6:33 pm, ?? ? wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> I want to use `jhsdb debugd` on my laptop.
>>>>>>>> However debugd mode has different options from other modes.
>>>>>>>> I think debugd should have same options like other modes.
>>>>>>>>
>>>>>>>> For example, `jhsdb debugd <pid>` should be `jhsdb debugd --pid <pid>`.
>>>>>>>> Also I added `--serverid` option for serverid.
>>>>>>>>
>>>>>>>> I attached a patch for this enhancement.
>>>>>>>> This patch passes serviceability/sa jtreg tests.
>>>>>>>>
>>>>>>>> Testcase for debugd is available as serviceability/sa/sadebugd/SADebugDTest.java .
>>>>>>>> However it has been disabled by JDK-8163805.
>>>>>>>> It will be fixed by Yasumasa Suenaga (ysuenaga) after my proposal has been merged.
>>>>>>>>
>>>>>>>> Could you help? I want to contribute it. I need a sponsor.
>>>>>>>> (My company has signed to OCA (NTT Comware Corporation))
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Osamu
>>>>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Thanks,
>>>> Jc