RFR (XS) 8223779: Build failure after 8223040 (Add a AsyncGetCallTrace test)

[Jean Christophe Beyler]

Thanks Chris! Much appreciated,
Jc

*From: *Chris Plummer <chris.plummer at oracle.com>
*Date: *Mon, May 13, 2019 at 8:31 PM
*To: *Jean Christophe Beyler, serguei.spitsyn at oracle.com
*Cc: *OpenJDK Serviceability, Aleksey Shipilev

Sorry about the delay. Ran into a couple of issues (both my fault). After
> correcting them the testing went through ok.
>
> Chris
>
> On 5/13/19 1:36 PM, Chris Plummer wrote:
>
> I can do that.
>
> Chris
>
>
> On 5/13/19 1:33 PM, Jean Christophe Beyler wrote:
>
> Hi all,
>
> Submit repo seems down, could someone test it via mach1 testing please?
>
> Here is the webrev:Â
> http://cr.openjdk.java.net/~jcbeyler/8223779/webrev.00/
> Bug:Â https://bugs.openjdk.java.net/browse/JDK-8223779
>
> (Or I can wait until submit repo comes back online for me :-))
>
> Thanks!
> Jc
>
> *From: *serguei.spitsyn at oracle.com <serguei.spitsyn at oracle.com>
> *Date: *Mon, May 13, 2019 at 1:03 PM
> *To: *Chris Plummer, Jean Christophe Beyler, OpenJDK Serviceability
> *Cc: *Aleksey Shipilev
>
> On 5/13/19 09:21, Chris Plummer wrote:
>> Hi Jc,
>>
>> +1
>>
>> Thanks,
>> Serguei
>>
>>
>> Hi JC,
>>
>> Your fix is consistent with the one done for
>> https://bugs.openjdk.java.net/browse/JDK-8169261, so thumbs up.
>>
>> thanks,
>>
>> Chris
>>
>> On 5/13/19 8:18 AM, Jean Christophe Beyler wrote:
>>
>> Hi all,
>>
>> Here is a small patch for fixing a fastdebug linking error:
>>
>> Bug is :Â https://bugs.openjdk.java.net/browse/JDK-8223779
>> Diff is:
>>
>> diff -r 85ccac8a8c13 make/test/JtregNativeHotspot.gmk
>> --- a/make/test/JtregNativeHotspot.gmk  Mon May 13 16:43:47 2019 +0200
>> +++ b/make/test/JtregNativeHotspot.gmk  Mon May 13 08:13:11 2019 -0700
>> @@ -864,7 +864,7 @@
>> Â  Â  Â BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exestack-gap := -ljvm
>> -lpthread
>> Â  Â  Â BUILD_TEST_exeinvoke_exeinvoke.c_OPTIMIZATION := NONE
>> Â  Â  Â BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exeFPRegs := -ldl
>> -Â  Â  BUILD_HOTSPOT_JTREG_LIBRARIES_LDFLAGS_libAsyncGetCallTraceTest :=
>> -ldl
>> +Â  Â  BUILD_HOTSPOT_JTREG_LIBRARIES_LIBS_libAsyncGetCallTraceTest := -ldl
>> Â else
>> Â  Â BUILD_HOTSPOT_JTREG_EXCLUDE += libtest-rw.c libtest-rwx.c
>> libTestJNI.c \
>> Â  Â  Â  Â exeinvoke.c exestack-gap.c libAsyncGetCallTraceTest.cpp
>>
>> Important note: it passes with or without this patch on my dev machine
>> but  Aleksey Shipilev saw the failure and saw that the patch helps. So I
>> think this should be done; I'm sending it to the submit-repo at the same
>> time.
>>
>> Thanks,
>> Jc
>>
>>
>>
>>
>
> --
>
> Thanks,
> Jc
>
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190513/81844ce7/attachment-0001.html>