RFC: 8223740: Clarify Instrumentation interface should not be implemented outside java.instrument module

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Tue May 14 16:30:31 UTC 2019


Alan,

I've updated the CSR with @apiNote tag.
Could you, please, add yourself as a reviewer?

Thanks,
Serguei

On 5/14/19 03:46, Alan Bateman wrote:
> On 14/05/2019 03:36, serguei.spitsyn at oracle.com wrote:
>> :
>>
>>   Java SE 9 added two abstract module-aware methods to the interface
>>   java.lang.instrument.Instrumentation. The assumption at the time was
>>   that the Instrumentation implementation is tightly coupled to the VM
>>   implementation and it seemed unlikely there would be other 
>> implementations
>>   (this follows similar additions of abstract methods in Java SE 6).
> Right, Instrumentation wants to be a sealed type but doesn't have a 
> way to express this yet. Adding a statement to the javadoc seems okay 
> for now, I'm just wondering if it should use one of the javadoc tags 
> created for documenting API notes [1]. Joe Darcy (cc'ed) may have 
> input into this. It can probably be @apiNote as the statement is it 
> documenting intention.
>
> -Alan
>
> [1] https://openjdk.java.net/jeps/8068562



More information about the serviceability-dev mailing list