debugd options should regard to jhsdb style

[serguei.spitsyn at oracle.com]

Hi Osamu,


On 5/14/19 00:21, Osamu Sakamoto wrote:
> Hi Serguei,
>
> Thank you for reviewing the CSR.
>
> I answer your questions.
>
> Q1 & Q2: <executable image name> and <path to coredump> can accept 
> both full path and relative path.

It has to be clear in the help.
I've updated the CSR with this.

> Q3: Other commands (clhsdb/hsdb/jstack/jmap/jinfo/jsnap) currently 
> have the same format, and need not to be updated.

Thank you for the confirmation.

> By the way, you've added angle brackets to jhsdb debugd --help in the 
> CSR.
> But current other commands --help don't have it.
> I think this modification should be also added to other commands 
> --help if it is added to debugd --help.
> This CSR relates on only debugd, so I think this modification should 
> be included to the RFE which David filed.(JDK-8223814)
> What do you think about this?

I've added a comment about this to the RFE JDK-8223814.

>
> Yasumasa has uploaded webrev.00.1 that angle bracket is added to 
> debugd --help.
> I will request him to push the better one when this is clear
> <http://cr.openjdk.java.net/~ysuenaga/JDK-8223665/webrev.00.1/>

Okay, thanks!
I'll review it now.

Thanks,
Serguei

>
> Thanks,
> Osamu
>
>
> On 5/14/19 14:07, serguei.spitsyn at oracle.com wrote:
>> Hi Osamu,
>>
>> Sorry for reacting on this so late.
>> This work on cmd-line options unification is very welcome!
>>
>> I looked at the CSR and it looks pretty good in general.
>>
>> I've added angle brackets to the jhsdb debugd --help:
>>
>> |$ jhsdb debugd --help --serverid <unique id for this debug server> 
>> --exe <executable image name> --core <path to coredump> --pid <pid of 
>> process to attach> But this needs to be unified with other commands 
>> |||(clhsdb, hsdb, jstack, etc|), of course. |
>>
>> Also, added a comment with the questions:
>>
>> |Q1: Should the <executable image name> be always a full path name or 
>> it can be a relative path? Q2: Should the <path to coredump> be 
>> always a full path name or it can be a relative path? Q3: Do all 
>> other commans (clhsdb, hsdb, jstack, jmap, etc.) currently have the 
>> same format or they also need to be updated?|
>>
>>
>> I can update the CSR description if you answer these questions.
>> They'll file an RFE for this.
>>
>> Thanks,
>> Serguei
>>
>>
>>
>> On 5/13/19 01:06, Osamu Sakamoto wrote:
>>> Hi David,
>>>
>>> Thank you for updating the CSR.
>>> I agree with filing a RFE to improve the general jhsdb help output.
>>>
>>> Could you file the RFE? (I can't access JBS.)
>>> I would like to contribute it if the RFE will be filed.
>>>
>>> My proposal (webrev.00) has been reviewed by Yasumasa and JC.
>>> So I will request Yasumasa to push it to jdk/jdk when the status of 
>>> CSR changes to Approved, and RFE for jhsdb help is filed.
>>>
>>> Thanks,
>>> Osamu
>>>
>>>
>>> On 5/13/19 16:00, David Holmes wrote:
>>>>
>>>> On 13/05/2019 4:38 pm, Osamu Sakamoto wrote:
>>>>> Hi, David
>>>>>
>>>>> I saw your comment in this CSR.
>>>>> CSR: https://bugs.openjdk.java.net/browse/JDK-8223666
>>>>>
>>>>> I understand that the problem is that the help description of 
>>>>> debugd I proposed and current other modes is not helpful for users.
>>>>>
>>>>> What should we do to go through this CSR?
>>>>> IMHO we should update help description of all jhsdb modes more 
>>>>> helpful.
>>>>> Do you have any ideas about this?
>>>>
>>>> I think a RFE should be filed to improve the general jhsdb help 
>>>> output, so that it explains that --pid and --exe are mutually 
>>>> exclusive options. That way this CSR, and thus the associated RFE 
>>>> can proceed. I'll add the same info the CSR.
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>> Thanks,
>>>>> Osamu
>>>>>
>>>>>
>>>>> On 5/10/19 17:46, 坂本 統 wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I agree with Yasumasa's opinion in CSR.
>>>>>>
>>>>>> I wrote new debugd format and usage to match other modes(jstack, 
>>>>>> jmap and so on) in jhdsb.
>>>>>> Certainly, usage of debugd which I proposed does not explain that 
>>>>>> <pid> and <exe> cannot be used together, but it is not limited to 
>>>>>> debugd - other modes have similar issue.
>>>>>>
>>>>>> I think it is helpful to detail help description in each jhsdb 
>>>>>> modes, but I'd like to separate as another issue because this is 
>>>>>> not limited to debugd.
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Yasumasa Suenaga <yasuenag at gmail.com>
>>>>>> Sent: Friday, May 10, 2019 4:08 PM
>>>>>> To: David Holmes <david.holmes at oracle.com>
>>>>>> Cc: Jean Christophe Beyler <jcbeyler at google.com>; 
>>>>>> serviceability-dev at openjdk.java.net 
>>>>>> serviceability-dev at openjdk.java.net 
>>>>>> <serviceability-dev at openjdk.java.net>; 坂本 統 
>>>>>> <sakamoto.osamu at nttcom.co.jp>
>>>>>> Subject: Re: debugd options should regard to jhsdb style
>>>>>>
>>>>>> Hi David,
>>>>>>
>>>>>> Thank you for checking in CSR, and sorry for my incorrect 
>>>>>> description.
>>>>>> I added my opinion to CSR.
>>>>>>
>>>>>> Osamu, do you have any opinion?
>>>>>>
>>>>>>
>>>>>> Yasumasa
>>>>>>
>>>>>>
>>>>>> 2019年5月10日(金) 15:16 David Holmes <david.holmes at oracle.com>:
>>>>>>>
>>>>>>> Hi Yasumasa,
>>>>>>>
>>>>>>> I've made some updates to the CSR request and raised a couple of 
>>>>>>> issues.
>>>>>>>
>>>>>>> FYI the specification section only needs to contain the actual
>>>>>>> specification for what has changed ie the new command-line options;
>>>>>>> not the implementation that will bring about those changes.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> David
>>>>>>>
>>>>>>> On 10/05/2019 2:12 pm, Yasumasa Suenaga wrote:
>>>>>>>> Thanks JC!
>>>>>>>>
>>>>>>>> I added key point of this change to specification section in CSR.
>>>>>>>>
>>>>>>>>
>>>>>>>> Yasumasa
>>>>>>>>
>>>>>>>> 2019年5月10日(金) 12:54 Jean Christophe Beyler 
>>>>>>>> <jcbeyler at google.com>:
>>>>>>>>>
>>>>>>>>> Hi Yasumasa,
>>>>>>>>>
>>>>>>>>> I'm not a reviewer but the CSR looks good; I feel that the
>>>>>>>>> specification section could use some text and then send the 
>>>>>>>>> reader
>>>>>>>>> to the other bug entry :) Jc
>>>>>>>>>
>>>>>>>>> From: Yasumasa Suenaga <yasuenag at gmail.com>
>>>>>>>>> Date: Thu, May 9, 2019 at 8:06 PM
>>>>>>>>> To: serviceability-dev at openjdk.java.net
>>>>>>>>> serviceability-dev at openjdk.java.net
>>>>>>>>>
>>>>>>>>>> tests on submit repo have been passed
>>>>>>>>>> (mach5-one-ysuenaga-JDK-8223665-20190510-0157-2376640)
>>>>>>>>>>
>>>>>>>>>> Could you review the CSR?
>>>>>>>>>>
>>>>>>>>>>>      CSR: https://bugs.openjdk.java.net/browse/JDK-8223666
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Yasumasa
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 2019年5月10日(金) 10:20 Yasumasa Suenaga <yasuenag at gmail.com>:
>>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> Osamu, your change looks good to me.
>>>>>>>>>>> I will sponsor you.
>>>>>>>>>>>
>>>>>>>>>>> David, I filed this issue and requested to CSR:
>>>>>>>>>>>
>>>>>>>>>>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8223665
>>>>>>>>>>>      CSR: https://bugs.openjdk.java.net/browse/JDK-8223666
>>>>>>>>>>>
>>>>>>>>>>> I uploaded webrev. I will push it to submit repo.
>>>>>>>>>>>
>>>>>>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8223665/webrev.00/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>>
>>>>>>>>>>> Yasumasa
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 2019/05/10 7:30, David Holmes wrote:
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>> This will need a bug filed and a corresponding CSR request. I
>>>>>>>>>>>> suspect that historically the form of this command was done 
>>>>>>>>>>>> to match other tools.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>> David
>>>>>>>>>>>>
>>>>>>>>>>>> On 9/05/2019 6:33 pm, ?? ? wrote:
>>>>>>>>>>>>> Hi all,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I want to use `jhsdb debugd` on my laptop.
>>>>>>>>>>>>> However debugd mode has different options from other modes.
>>>>>>>>>>>>> I think debugd should have same options like other modes.
>>>>>>>>>>>>>
>>>>>>>>>>>>> For example, `jhsdb debugd <pid>` should be `jhsdb debugd 
>>>>>>>>>>>>> --pid <pid>`.
>>>>>>>>>>>>> Also I added `--serverid` option for serverid.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I attached a patch for this enhancement.
>>>>>>>>>>>>> This patch passes serviceability/sa jtreg tests.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Testcase for debugd is available as 
>>>>>>>>>>>>> serviceability/sa/sadebugd/SADebugDTest.java .
>>>>>>>>>>>>> However it has been disabled by JDK-8163805.
>>>>>>>>>>>>> It will be fixed by Yasumasa Suenaga (ysuenaga) after my 
>>>>>>>>>>>>> proposal has been merged.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Could you help? I want to contribute it. I need a sponsor.
>>>>>>>>>>>>> (My company has signed to OCA (NTT Comware Corporation))
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Osamu
>>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> -- 
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Jc
>>