RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

[David Holmes]

On 17/05/2019 12:26 am, Jean Christophe Beyler wrote:
>  From my experience, some compiler in Solaris/Windows complain about 
> this (or used to a year ago via the submit repo); Serguei and I had to 
> do this dance when we were getting the heap monitoring tests in. An 

I think the tests are different. This file is part of the main build and 
is being built the same way as all the other .c files in the core 
libraries. The Windows and Solaris sources already contain code with 
loop variable declarations. Yet much to my surprise the shared sources 
do not - seems gcc is the weak link here. :(

> alternative is to move the file to a C++ file. Adding an extern "C" at 
> the top would make symbols not be mangled and it should "work"  without 
> having to go to old-C requirements.

Not sure if that's feasible.

Cheers,
David
-----

> Thanks,
> Jc
> 
> On Thu, May 16, 2019 at 5:31 AM David Holmes <david.holmes at oracle.com 
> <mailto:david.holmes at oracle.com>> wrote:
> 
>     What compiler was used here? We shouldn't be using anything that
>     doesn't
>     handle loop variable declarations!
> 
>     Thanks,
>     David
> 
>     On 16/05/2019 7:41 pm, Daniel Fuchs wrote:
>      > Hi Ao Qi,
>      >
>      > I'm adding serviceability-dev, since this is for jdwp.
>      >
>      > The proposed changes look good to me - but please get
>      > someone from the serviceability team to review this.
>      >
>      > best regards,
>      >
>      > -- daniel
>      >
>      >
>      > On 16/05/2019 08:41, Ao Qi wrote:
>      >> Hi,
>      >>
>      >> I found build is failed on CentOS 7.6, because of loop initial
>      >> declarations. Could I please get reviews for this?
>      >>
>      >> Bug:
>      >> https://bugs.openjdk.java.net/browse/JDK-8224028
>      >>
>      >> Webrev:
>      >> http://cr.openjdk.java.net/~aoqi/8224028/webrev.00/
>      >>
>      >> Tested:
>      >> linux-x86_64-server-release tier1
>      >>
>      >> Thanks,
>      >> Ao Qi
>      >>
>      >
> 
> 
> 
> -- 
> 
> Thanks,
> Jc