RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace

[Doerr, Martin]

Hi Götz and JC,

thanks for reviewing.

Best regards,
Martin


From: Jean Christophe Beyler <jcbeyler at google.com>
Sent: Montag, 20. Mai 2019 18:34
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Cc: Doerr, Martin <martin.doerr at sap.com>; serviceability-dev at openjdk.java.net; Volker Simonis (volker.simonis at gmail.com) <volker.simonis at gmail.com>
Subject: Re: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace

Hi Martin,

Looks good to me too :)
Jc

On Mon, May 20, 2019 at 8:56 AM Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>> wrote:
LGTM
  Goetz!

> -----Original Message-----
> From: Doerr, Martin
> Sent: Montag, 20. Mai 2019 17:49
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>; serviceability-
> dev at openjdk.java.net<mailto:dev at openjdk.java.net>; JC Beyler <jcbeyler at google.com<mailto:jcbeyler at google.com>>; Volker Simonis
> (volker.simonis at gmail.com<mailto:volker.simonis at gmail.com>) <volker.simonis at gmail.com<mailto:volker.simonis at gmail.com>>
> Subject: RE: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace
>
> Hi Götz,
>
> thanks for reviewing it so quickly.
>
> Thanks for pointing me to the obsolete comment. I've also fixed in on PPC64
> and also removed a redundant assertion on PPC64:
> http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr
> ev.01/
>
> I haven't used async profiler, but I've ran JTREG tests for hotspot runtime on
> linux PPC64 (Big and Little Endian) and s390 and all ones have passed.
>
> Best regards,
> Martin
>
>
> -----Original Message-----
> From: Lindenmaier, Goetz
> Sent: Montag, 20. Mai 2019 17:36
> To: Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>; serviceability-
> dev at openjdk.java.net<mailto:dev at openjdk.java.net>; JC Beyler <jcbeyler at google.com<mailto:jcbeyler at google.com>>; Volker Simonis
> (volker.simonis at gmail.com<mailto:volker.simonis at gmail.com>) <volker.simonis at gmail.com<mailto:volker.simonis at gmail.com>>
> Subject: RE: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace
>
> Hi Martin,
>
> the changes look good.
>
> Please fix this comment:
>  // Forte Analyzer AsyncGetCallTrace profiling support is not implemented on
> Linux/S390x.
> I guess it's no more true.  No new webrev needed.
>
> Did you verify that the test works, or did you also try
> async with the VM on ppc?
>
> Best regards,
>   Goetz.
>
> > -----Original Message-----
> > From: Doerr, Martin
> > Sent: Montag, 20. Mai 2019 17:32
> > To: serviceability-dev at openjdk.java.net<mailto:serviceability-dev at openjdk.java.net>; JC Beyler <jcbeyler at google.com<mailto:jcbeyler at google.com>>;
> > Volker Simonis (volker.simonis at gmail.com<mailto:volker.simonis at gmail.com>) <volker.simonis at gmail.com<mailto:volker.simonis at gmail.com>>;
> > Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>
> > Subject: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace
> >
> > Hi,
> >
> >
> >
> > please review my change which allows usage of AsyncGetCallTrace on PPC64
> > and s390.
> >
> >
> >
> > Webrev:
> >
> >
> http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr
> > ev.00/
> >
> >
> >
> > Bug with more background information:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8224230
> >
> >
> >
> > Best regards,
> >
> > Martin
> >
> >


--

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190520/49635fe3/attachment-0001.html>