RFR (XS): 8046018: JVMTI Spec: can_redefine_any_class capability spec is inconsistent

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon May 20 20:38:20 UTC 2019


Hi Chris,


On 5/20/19 13:19, Chris Plummer wrote:
> Hi Serguei,
>
> Looks good.

Thanks a lot!

> I think you should make a minor change in the comment: "It tells now" 
> should be "It now says".

Okay, thanks.

> Also, your summary comment below says "inconsistent" instead of 
> "consistent".

Good catch!


> You should fix that in your commit comment.

Fixed in place.

Thanks,
Serguei

>
> thanks,
>
> Chris
>
> On 5/20/19 11:07 AM, serguei.spitsyn at oracle.com wrote:
>> Please, review a fix for enhancement:
>> https://bugs.openjdk.java.net/browse/JDK-8046018
>>
>> Related CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8223915
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8046018-jvmti-cap-spec.1/
>>
>>
>> Summary:
>>
>>   The fix is to make the JVMTI can_redefine_any_class capability spec 
>> more inconsistent.
>>   It is just about a couple of lines.
>>
>> Thanks,
>> Serguei
>
>



More information about the serviceability-dev mailing list