8223814: SA: jhsdb common help needs to be more detailed

[Osamu Sakamoto]

Hi Serguei,

Thank for reviewing.

 > But could you, please, send the output that the help command will print
 > with your fix?
I attached all fixed --help 
outputs(clhsdb/debugd/hsdb/jstack/jmap/jinfo/jsnap) to this email.

Thanks,
Osamu



On 5/24/19 03:43, serguei.spitsyn at oracle.com wrote:
> Hi Osamu,
> 
> It looks Okay to me.
> But could you, please, send the output that the help command will print 
> with your fix?
> 
> Thanks,
> Serguei
> 
> 
> On 5/23/19 02:34, Osamu Sakamoto wrote:
>> Hi all,
>>
>> I've made the patch that was discussed here.
>> <https://mail.openjdk.java.net/pipermail/serviceability-dev/2019-May/028042.html> 
>>
>>
>> This patch fixes the following JBS ticket.
>> <https://bugs.openjdk.java.net/browse/JDK-8223814>
>>
>> I attached the patch to this email.
>> This patch passes serviceability/sa jtreg tests.
>>
>> Could you help? I would like to contribute it. I need a sponsor.
>> (My company has signed to OCA (NTT Comware Corporation))
>>
>>
>> Thanks,
>> Osamu
> 
-------------- next part --------------
$jhsdb clhsdb --help
    --exe       <executable image name>
    --core      <path to coredump>
    --pid       <pid of process to attach>

    --pid and --exe are mutually execlusive, and --core only goes with --exe.
    Arguments following the --exe and --core can be absolute or relative path.

    Examples: jhsdb clhsdb --pid <pid>
          or  jhsdb clhsdb --exe <executable> --core <core>
$jhsdb debugd --help
    --serverid  <unique id for this debug server>
    --exe       <executable image name>
    --core      <path to coredump>
    --pid       <pid of process to attach>

    --pid and --exe are mutually execlusive, and --core only goes with --exe.
    Arguments following the --exe and --core can be absolute or relative path.

    Examples: jhsdb debugd --pid <pid>
          or  jhsdb debugd --exe <executable> --core <core>
$jhsdb hsdb --help
    --exe       <executable image name>
    --core      <path to coredump>
    --pid       <pid of process to attach>

    --pid and --exe are mutually execlusive, and --core only goes with --exe.
    Arguments following the --exe and --core can be absolute or relative path.

    Examples: jhsdb hsdb --pid <pid>
          or  jhsdb hsdb --exe <executable> --core <core>
$jhsdb jstack --help
    --locks     <to print java.util.concurrent locks>
    --mixed     <to print both java and native frames (mixed mode)>
    --exe       <executable image name>
    --core      <path to coredump>
    --pid       <pid of process to attach>

    --pid and --exe are mutually execlusive, and --core only goes with --exe.
    Arguments following the --exe and --core can be absolute or relative path.

    Examples: jhsdb jstack --pid <pid>
          or  jhsdb jstack --exe <executable> --core <core>
$jhsdb jmap --help
    <no option> <to print same info as Solaris pmap>
    --heap      <to print java heap summary>
    --binaryheap        <to dump java heap in hprof binary format>
    --dumpfile  <name of the dump file>
    --histo     <to print histogram of java object heap>
    --clstats   <to print class loader statistics>
    --finalizerinfo     <to print information on objects awaiting finalization>
    --exe       <executable image name>
    --core      <path to coredump>
    --pid       <pid of process to attach>

    --pid and --exe are mutually execlusive, and --core only goes with --exe.
    Arguments following the --exe and --core can be absolute or relative path.

    Examples: jhsdb jmap --pid <pid>
          or  jhsdb jmap --exe <executable> --core <core>
$jhsdb jinfo --help
    --flags     <to print VM flags>
    --sysprops  <to print Java System properties>
    <no option> <to print both of the above>
    --exe       <executable image name>
    --core      <path to coredump>
    --pid       <pid of process to attach>

    --pid and --exe are mutually execlusive, and --core only goes with --exe.
    Arguments following the --exe and --core can be absolute or relative path.

    Examples: jhsdb jinfo --pid <pid>
          or  jhsdb jinfo --exe <executable> --core <core>
$jhsdb jsnap --help
    --all       <to print all performance counters>
    --exe       <executable image name>
    --core      <path to coredump>
    --pid       <pid of process to attach>

    --pid and --exe are mutually execlusive, and --core only goes with --exe.
    Arguments following the --exe and --core can be absolute or relative path.

    Examples: jhsdb jsnap --pid <pid>
          or  jhsdb jsnap --exe <executable> --core <core