RFR(S): 8169467: GetLocalInstance returns JVMTI_ERROR_TYPE_MISMATCH (rather than JVMTI_ERROR_INVALID_SLOT) on static method

Alex Menkov alexey.menkov at oracle.com
Wed Nov 20 23:32:10 UTC 2019


Looks good.

--alex

On 11/19/2019 15:36, serguei.spitsyn at oracle.com wrote:
> Please, review a fix for:
>    https://bugs.openjdk.java.net/browse/JDK-8169467
> 
> Webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8169467-jvmti-local-instance.1/ 
> 
> 
> Summary:
>    The JVMTI GetLocalInstance function should return 
> JVMTI_ERROR_INVALID_SLOT for static method frames.
>    Instead, it returns the JVMTI_ERROR_TYPE_MISMATCH error.
>    The fix adds necessary checks into the implementation.
> 
> Testing in progress:
>    - Locally on Linux-x64 with: vmTestbase_nsk_jvmti, 
> vmTestbase_nsk_jdi, jdk_jdi
>    - All mach5 hs-tier5
> 
> Thanks,
> Serguei


More information about the serviceability-dev mailing list