[UNVERIFIED SENDER] RFR(XXS): 8231768: Remove duplicate if/else in vmTestbase/nsk/share/jdi/Binder.java

Leonid Mesnik leonid.mesnik at oracle.com
Wed Oct 2 18:18:38 UTC 2019


Thank you for review.

Leonid

> On Oct 2, 2019, at 11:14 AM, Hohensee, Paul <hohensee at amazon.com> wrote:
> 
> Looks good.
>  
> Paul
>  
> From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net <mailto:serviceability-dev-bounces at openjdk.java.net>> on behalf of Leonid Mesnik <leonid.mesnik at oracle.com <mailto:leonid.mesnik at oracle.com>>
> Date: Wednesday, October 2, 2019 at 11:12 AM
> To: serviceability-dev <serviceability-dev at openjdk.java.net <mailto:serviceability-dev at openjdk.java.net>>
> Subject: [UNVERIFIED SENDER] RFR(XXS): 8231768: Remove duplicate if/else in vmTestbase/nsk/share/jdi/Binder.java
>  
> Hi 
>  
> Could you please review following tiny and trivial fix which just remove duplicated if/else branch in nsk/share/jdi/Binder class.
>  
> Verified that all tests still pass locally.
>  
> webrev: http://cr.openjdk.java.net/~lmesnik/8231768/webrev.00/ <http://cr.openjdk.java.net/~lmesnik/8231768/webrev.00/>
> bug: https://bugs.openjdk.java.net/browse/JDK-8231768 <https://bugs.openjdk.java.net/browse/JDK-8231768>
>  
> Leonid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20191002/b48adab2/attachment-0001.html>


More information about the serviceability-dev mailing list