RFR: 8232370: Refactor some com.sun.jdi tests to enable IDE integration

Langer, Christoph christoph.langer at sap.com
Thu Oct 17 20:45:31 UTC 2019


Thanks for the reviews.

> -----Original Message-----
> From: Chris Plummer <chris.plummer at oracle.com>
> Sent: Mittwoch, 16. Oktober 2019 21:30
> To: Alex Menkov <alexey.menkov at oracle.com>; Langer, Christoph
> <christoph.langer at sap.com>; OpenJDK Serviceability <serviceability-
> dev at openjdk.java.net>
> Subject: Re: RFR: 8232370: Refactor some com.sun.jdi tests to enable IDE
> integration
> 
> +1
> 
> On 10/16/19 11:54 AM, Alex Menkov wrote:
> > Ho Christoph,
> >
> > Looks good to me.
> >
> > --alex
> >
> > On 10/16/2019 07:10, Langer, Christoph wrote:
> >> Hi,
> >>
> >> please review this little test refactoring to better support IDE
> >> integration. There are a few classes defined twice in the com/sun/jdi
> >> test folder and hence cause ambiguity problems if the whole folder is
> >> added to a project in the Eclipse IDE.
> >>
> >> I ran the com/sun/jdi tests with my refactoring and they still pass.
> >>
> >> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8232370.0/
> >>
> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8232370
> >>
> >> Thanks
> >>
> >> Christoph
> >>



More information about the serviceability-dev mailing list