RFR: JDK-8232973: Potential infinite loop in macOS hotspot agent

Simon Tooke stooke at redhat.com
Thu Oct 24 14:16:07 UTC 2019


Hello,

While reviewing uses of strtok() with an eye to moving to strtok_r(), I 
came accross an inifinite loop in the macOS agent code, but one that has 
probably never been executed.  In the interests of not having even 
potential loops, I've file a bug and have a PR to submit.  My patch 
removes the inifinite loop and switches to strtok_r().  The switch to 
the reentrant version is not required in this use case but I include it 
so that this code doesn't show up on future scans for strtok() usage.

Bug: https://bugs.openjdk.java.net/browse/JDK-8232973

Webrev: http://cr.openjdk.java.net/~stooke/webrevs/jdk-8232973-jdk/00/

Are there any concerns?

Thanks,

-Simon





More information about the serviceability-dev mailing list