RFR: JDK-8192057: com/sun/jdi/BadHandshakeTest.java fails with java.net.ConnectException

[serguei.spitsyn at oracle.com]

Hi Alex,

The fix looks good.
Good simplification!

Thanks,
Serguei


On 9/4/19 12:19, Alex Menkov wrote:
> Hi all,
>
> Please review the fix for BadHandshakeTest test.
> The problem is the test connects to the server twice and if debuggee 
> hasn't yet handled disconnection, the next connect gets "connection 
> refused" error.
> Instead of adding delay before 2nd connect (we never know "good" value 
> for the delay and big delay can cause "accept timeout"), the test 
> re-tries connect in case of ConnectException.
> Also improved/simplified the test slightly - debuggee is now run with 
> auto port assignment (used lib.jdb.Debuggee test class which 
> implements required functionality).
>
> jira:
>   https://bugs.openjdk.java.net/browse/JDK-8192057
> webrev:
> http://cr.openjdk.java.net/~amenkov/jdk14/BadHandshakeTest/webrev/
>
> --alex