RFR: 8230830: No required ResourceMark in src/hotspot/share/prims/jvmtiImpl.cpp:JvmtiSuspendControl::print()

David Holmes david.holmes at oracle.com
Wed Sep 11 05:03:08 UTC 2019


Hi Leonid,

On 11/09/2019 12:03 pm, Leonid Mesnik wrote:
> Hi
> 
> Could you please review following tiny fix which just add ResourceMark 
> in JvmtiSuspendControl::print() method.

Looks fine.

> The method jvmtiSuspendControl::print() might used in custom builds only 
> for debugging purposes. So I don't know when it was used last time. I 
> found that it crashes when I tried to use it locally.

The only caller is JvmtiEnv::NotifyFramePop, under TraceJVMTICalls, and 
it already has a ResourceMark. So existing use is fine.

Please ensure you test with TraceJVMTICalls enabled.

Thanks,
David


> webrev: http://cr.openjdk.java.net/~lmesnik/8230830/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8230830
> 
> Leonid
> 
> 


More information about the serviceability-dev mailing list