RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

David Holmes david.holmes at oracle.com
Tue Sep 24 06:15:09 UTC 2019


Hi Evgeny,

I just spotted this review request languishing in the mailing list.

On 26/08/2019 4:36 am, Evgeny Mandrikov wrote:
> Hello!
> 
> Please review patch [1] for JDK-8199136 [2]. Also it needs a sponsor 
> since I have only author status in OpenJDK Census [3].

I looked at the discussion in the bug report (which I've assigned to 
you) and looked at the code and agree that these API's are unused and so 
the code can be cleaned up.

The patch will need to be rebased against latest jdk sources, so please 
do that. I'll see if I can drum up a second reviewer and get a sponsor.

Thanks,
David

> After this change tier1 tests pass on my machine.
> 
> 
> With best regards,
> Evgeny Mandrikov
> 
> [1] http://cr.openjdk.java.net/~godin/8199136/webrev.00/
> [2] https://bugs.openjdk.java.net/browse/JDK-8199136
> [3] https://openjdk.java.net/census#godin
> 


More information about the serviceability-dev mailing list