JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

[Daniil Titov]

Hi Evgeny,

 

The change looks good to me.

 

Thanks!

--Daniil

 

From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net> on behalf of Evgeny Mandrikov <mandrikov at gmail.com>
Date: Tuesday, September 24, 2019 at 1:32 AM
To: David Holmes <david.holmes at oracle.com>
Cc: <serviceability-dev at openjdk.java.net>
Subject: Re: RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

 

On Tue, Sep 24, 2019 at 8:15 AM David Holmes <david.holmes at oracle.com> wrote:

I just spotted this review request languishing in the mailing list.

 

The patch will need to be rebased against latest jdk sources, so please 
do that. I'll see if I can drum up a second reviewer and get a sponsor.

 

Hi David,

 

No pb, here is rebased patch - http://cr.openjdk.java.net/~godin/8199136/webrev.01/

 

 

Regards,

Evgeny

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190924/09c0ecc8/attachment.html>