RFR (M): 8231595 [TEST] develop a test case for SuspendThreadList including current thread

David Holmes david.holmes at oracle.com
Sat Sep 28 23:53:35 UTC 2019


Hi Serguei,

On 28/09/2019 11:25 am, serguei.spitsyn at oracle.com wrote:
> Please, review fix for test enhancement:
>    https://bugs.openjdk.java.net/browse/JDK-8231595
> 
> Webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8231595-jvmti-susp-tlist.1/ 

Sorry but I could barely follow the logic of that test at all. Can you 
please write a comment block that clearly explains what the test is doing.

I still don't understand how JDK-8217762 is "not an issue". Possibly the 
suspend request on the current thread doesn't actually take effect until 
it tries to return to Java code, but I'm unsure.

Thanks,
David

> 
> Summary:
>    New test is a coverage for the JVMTI bug:
>      https://bugs.openjdk.java.net/browse/JDK-8217762
>        SuspendThreadList won't work correctly if the current thread is 
> not last in the list
> 
>    It provides a prove the bug JDK-8217762 does not exist
>    as the test is passed with the current implementation.
> 
> Thanks,
> Serguei


More information about the serviceability-dev mailing list