RFR: 8241958: Slow ClassLoaderReferenceImpl.findType

Chris Plummer chris.plummer at oracle.com
Fri Apr 3 18:30:45 UTC 2020


Hi Egor,

The changes look fine. Please update the copyrights before pushing.

thanks,

Chris

On 4/3/20 2:16 AM, Egor Ushakov wrote:
> Hi all, please review the fix
>
> The com.sun.tools.jdi.ClassLoaderReferenceImpl#findType may be slow 
> because ClassLoaderReferenceImpl#visibleClasses does not populate 
> signature and we check it for every class in the loop just after, so 
> requesting all unavailable signatures one by one.
> The fix adds extra check in classesBySignature before comparing 
> signatures of all visible classes.
>
> bugid https://bugs.openjdk.java.net/browse/JDK-8241958
> cr http://cr.openjdk.java.net/~eushakov/8241958/webrev.00/
>
> Thanks!
>



More information about the serviceability-dev mailing list