RFR(S) 8242142: convert clhsdb "class" and "classes" commands from javascript to java

[serguei.spitsyn at oracle.com]

Hi Chris,

This looks good.

Thanks,
Serguei



On 4/6/20 17:07, Chris Plummer wrote:
> Can I get one more review please?
>
> thanks,
>
> Chris
>
> On 4/3/20 6:56 PM, Chris Plummer wrote:
>> Here's an updated webrev. I also renamed APP_CLASSNAME to 
>> APP_SLASH_CLASSNAME just to make it a bit more clear which format is 
>> being used.
>>
>> http://cr.openjdk.java.net/~cjplummer/8242142/webrev.01
>>
>> thanks,
>>
>> Chris
>>
>> On 4/3/20 6:13 PM, Chris Plummer wrote:
>>> Ok, I'll make those changes. Thanks for the review.
>>>
>>> Chris
>>>
>>> On 4/3/20 5:44 PM, Alex Menkov wrote:
>>>> Hi Chris,
>>>>
>>>> The fix looks good.
>>>> Couple minor notes about the test:
>>>>
>>>>  41     static final String APP_CLASSNAME = 
>>>> "jdk/test/lib/apps/LingeredApp";
>>>>   42     static final String APP_DOT_CLASSNAME = 
>>>> APP_CLASSNAME.replace('/', '.');
>>>>
>>>> I'd make this
>>>> static final String APP_DOT_CLASSNAME = LingeredApp.class.getName();
>>>> static final String APP_CLASSNAME = APP_DOT_CLASSNAME.replace('.', 
>>>> '/');
>>>>
>>>>
>>>>
>>>>  52             theApp = new LingeredApp();
>>>>  53             LingeredApp.startApp(theApp);
>>>>
>>>> can be just
>>>>
>>>> theApp = LingeredApp.startApp();
>>>>
>>>> --alex
>>>>
>>>> On 04/03/2020 15:08, Chris Plummer wrote:
>>>>> Hello,
>>>>>
>>>>> Please review the following:
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8242142
>>>>> http://cr.openjdk.java.net/~cjplummer/8242142/webrev.00/
>>>>>
>>>>> See the CR for details. Note the output for the "class" command 
>>>>> looks like:
>>>>>
>>>>>      jdk/test/lib/apps/LingeredApp @0x0000000800bcb040
>>>>>
>>>>> The output for "classes" is the same, except each class is listed. 
>>>>> The output for "print <classaddr>" is kind of long, but includes 
>>>>> the following line, which the test looks for to verify the "class" 
>>>>> output.
>>>>>
>>>>>      public class jdk.test.lib.apps.LingeredApp @0x0000000800bcb040
>>>>>
>>>>> thanks,
>>>>>
>>>>> Chris
>>>>>
>>>
>>>
>>
>>
>
>